All revisions of the PinePhone share most of the hardware.
This patch makes it easier to detect PinePhone hardware without
having to check for each possible revision.
Signed-off-by: Dylan Van Assche <[email protected]>
---
arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts | 2 +-
arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts | 2 +-
arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts
index 3d5a2ae9aa39..fb65319a3bd3 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts
@@ -7,7 +7,7 @@
/ {
model = "Pine64 PinePhone Developer Batch (1.0)";
- compatible = "pine64,pinephone-1.0", "allwinner,sun50i-a64";
+ compatible = "pine64,pinephone-1.0", "pine64,pinephone", "allwinner,sun50i-a64";
};
&sgm3140 {
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts
index c9b9f6e9ee8c..5e59d3752178 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts
@@ -7,7 +7,7 @@
/ {
model = "Pine64 PinePhone Braveheart (1.1)";
- compatible = "pine64,pinephone-1.1", "allwinner,sun50i-a64";
+ compatible = "pine64,pinephone-1.1", "pine64,pinephone", "allwinner,sun50i-a64";
};
&backlight {
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts
index acc0ab53b9c1..4e7e237cb46a 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts
@@ -7,7 +7,7 @@
/ {
model = "Pine64 PinePhone (1.2)";
- compatible = "pine64,pinephone-1.2", "allwinner,sun50i-a64";
+ compatible = "pine64,pinephone-1.2", "pine64,pinephone", "allwinner,sun50i-a64";
wifi_pwrseq: wifi-pwrseq {
compatible = "mmc-pwrseq-simple";
--
2.26.2
On Tue, Dec 29, 2020 at 11:42 PM Dylan Van Assche <[email protected]> wrote:
>
> All revisions of the PinePhone share most of the hardware.
> This patch makes it easier to detect PinePhone hardware without
> having to check for each possible revision.
Sounds good.
> Signed-off-by: Dylan Van Assche <[email protected]>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts | 2 +-
> arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts | 2 +-
> arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts | 2 +-
Please also update the DT binding file:
Documentation/devicetree/bindings/arm/sunxi.yaml
ChenYu
Hi,
Good point!
I will send a new version of the patch soon.
Kind regards,
Dylan Van Assche
On Wed, 2020-12-30 at 17:38 +0800, Chen-Yu Tsai wrote:
> On Tue, Dec 29, 2020 at 11:42 PM Dylan Van Assche <
> [email protected]> wrote:
> > All revisions of the PinePhone share most of the hardware.
> > This patch makes it easier to detect PinePhone hardware without
> > having to check for each possible revision.
>
> Sounds good.
>
> > Signed-off-by: Dylan Van Assche <[email protected]>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts | 2 +-
> > arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts | 2 +-
> > arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts | 2 +-
>
> Please also update the DT binding file:
>
> Documentation/devicetree/bindings/arm/sunxi.yaml
>
> ChenYu