2021-01-07 12:21:21

by Martin Kepplinger

[permalink] [raw]
Subject: [PATCH v4 3/5] dt-bindings: mxsfb: Add interconnect bindings for LCDIF path

Add optional interconnect properties for the dram path requests.

Signed-off-by: Martin Kepplinger <[email protected]>
---
Documentation/devicetree/bindings/display/mxsfb.txt | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/mxsfb.txt b/Documentation/devicetree/bindings/display/mxsfb.txt
index c985871c46b3..d494a2674290 100644
--- a/Documentation/devicetree/bindings/display/mxsfb.txt
+++ b/Documentation/devicetree/bindings/display/mxsfb.txt
@@ -15,6 +15,12 @@ Required properties:
- "pix" for the LCDIF block clock
- (MX6SX-only) "axi", "disp_axi" for the bus interface clock

+Optional properties:
+- interconnects : interconnect path specifier for LCDIF according to
+ Documentation/devicetree/bindings/interconnect/interconnect.txt.
+- interconnect-names: the name describing the interconnect path.
+ Should be "dram" for i.MX8MQ.
+
Required sub-nodes:
- port: The connection to an encoder chip.

--
2.20.1


2021-01-14 19:16:52

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v4 3/5] dt-bindings: mxsfb: Add interconnect bindings for LCDIF path

On Mon, Jan 11, 2021 at 09:22:40AM +0100, Martin Kepplinger wrote:
> Add optional interconnect properties for the dram path requests.
>
> Signed-off-by: Martin Kepplinger <[email protected]>
> ---
> Documentation/devicetree/bindings/display/mxsfb.txt | 6 ++++++
> 1 file changed, 6 insertions(+)

Looks fine, but I believe there's an in flight patch to convert this to
schema. Please coordinate with that.

>
> diff --git a/Documentation/devicetree/bindings/display/mxsfb.txt b/Documentation/devicetree/bindings/display/mxsfb.txt
> index c985871c46b3..d494a2674290 100644
> --- a/Documentation/devicetree/bindings/display/mxsfb.txt
> +++ b/Documentation/devicetree/bindings/display/mxsfb.txt
> @@ -15,6 +15,12 @@ Required properties:
> - "pix" for the LCDIF block clock
> - (MX6SX-only) "axi", "disp_axi" for the bus interface clock
>
> +Optional properties:
> +- interconnects : interconnect path specifier for LCDIF according to
> + Documentation/devicetree/bindings/interconnect/interconnect.txt.
> +- interconnect-names: the name describing the interconnect path.
> + Should be "dram" for i.MX8MQ.
> +
> Required sub-nodes:
> - port: The connection to an encoder chip.
>
> --
> 2.20.1
>