2021-01-14 18:08:56

by Helen Koike

Subject: [PATCH 3/3] media: videobuf2-v4l2: remove redundant error test

request_fd is validated under media_request_get_by_fd() just below this
check. Thus remove it.

Suggested-by: Tomasz Figa <[email protected]>
Signed-off-by: Helen Koike <[email protected]>
---
drivers/media/common/videobuf2/videobuf2-v4l2.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c b/drivers/media/common/videobuf2/videobuf2-v4l2.c
index 96d3b2b2aa31..bb642c0775d1 100644
--- a/drivers/media/common/videobuf2/videobuf2-v4l2.c
+++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c
@@ -488,11 +488,6 @@ static int vb2_queue_or_prepare_buf(struct vb2_queue *q, struct media_device *md
!q->ops->buf_out_validate))
return -EINVAL;

- if (b->request_fd < 0) {
- dprintk(q, 1, "%s: request_fd < 0\n", opname);
- return -EINVAL;
- }
-
req = media_request_get_by_fd(mdev, b->request_fd);
if (IS_ERR(req)) {
dprintk(q, 1, "%s: invalid request_fd\n", opname);
--
2.29.2

2021-01-16 23:27:09

by Sakari Ailus

Subject: Re: [PATCH 3/3] media: videobuf2-v4l2: remove redundant error test

On Thu, Jan 14, 2021 at 03:01:49PM -0300, Helen Koike wrote:
> request_fd is validated under media_request_get_by_fd() just below this
> check. Thus remove it.
>
> Suggested-by: Tomasz Figa <[email protected]>
> Signed-off-by: Helen Koike <[email protected]>

Reviewed-by: Sakari Ailus <[email protected]>

--
Sakari Ailus