2021-01-16 12:03:59

by angkery

[permalink] [raw]

Subject: [PATCH] power: supply: charger-manager: fix the wrong status of health

---

From: Junlin Yang <[email protected]>

cm->emergency_stop will only be the value in the enumeration,
and can not be less than zero, it will get an exception value.
So replace it with the corresponding value.

Signed-off-by: Junlin Yang <[email protected]>
---
drivers/power/supply/charger-manager.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c
index 6fcebe4..0d28741 100644
--- a/drivers/power/supply/charger-manager.c
+++ b/drivers/power/supply/charger-manager.c
@@ -723,9 +723,9 @@ static int charger_get_property(struct power_supply *psy,
val->intval = cm->battery_status;
break;
case POWER_SUPPLY_PROP_HEALTH:
- if (cm->emergency_stop > 0)
+ if (cm->emergency_stop == CM_BATT_OVERHEAT)
val->intval = POWER_SUPPLY_HEALTH_OVERHEAT;
- else if (cm->emergency_stop < 0)
+ else if (cm->emergency_stop == CM_BATT_COLD)
val->intval = POWER_SUPPLY_HEALTH_COLD;
else
val->intval = POWER_SUPPLY_HEALTH_GOOD;
--
1.9.1

2021-01-16 17:13:30

by Sebastian Reichel

[permalink] [raw]

Subject: Re: [PATCH] power: supply: charger-manager: fix the wrong status of health

---

Hi,

On Sat, Jan 16, 2021 at 07:41:20PM +0800, angkery wrote:
> From: Junlin Yang <[email protected]>
>
> cm->emergency_stop will only be the value in the enumeration,
> and can not be less than zero, it will get an exception value.
> So replace it with the corresponding value.
>
> Signed-off-by: Junlin Yang <[email protected]>
> ---

Thanks, queued.

-- Sebastian

> drivers/power/supply/charger-manager.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c
> index 6fcebe4..0d28741 100644
> --- a/drivers/power/supply/charger-manager.c
> +++ b/drivers/power/supply/charger-manager.c
> @@ -723,9 +723,9 @@ static int charger_get_property(struct power_supply *psy,
> val->intval = cm->battery_status;
> break;
> case POWER_SUPPLY_PROP_HEALTH:
> - if (cm->emergency_stop > 0)
> + if (cm->emergency_stop == CM_BATT_OVERHEAT)
> val->intval = POWER_SUPPLY_HEALTH_OVERHEAT;
> - else if (cm->emergency_stop < 0)
> + else if (cm->emergency_stop == CM_BATT_COLD)
> val->intval = POWER_SUPPLY_HEALTH_COLD;
> else
> val->intval = POWER_SUPPLY_HEALTH_GOOD;
> --
> 1.9.1
>
>

---

Attachments:

(No filename) (1.22 kB)
signature.asc (849.00 B)
Download all attachments