2021-01-28 07:27:42

by Chaitanya Kulkarni

Subject: [RFC PATCH 26/34] xfs: use bio_new in xfs_rw_bdev

Signed-off-by: Chaitanya Kulkarni <[email protected]>
---
fs/xfs/xfs_bio_io.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/fs/xfs/xfs_bio_io.c b/fs/xfs/xfs_bio_io.c
index e2148f2d5d6b..e4644f22ebe6 100644
--- a/fs/xfs/xfs_bio_io.c
+++ b/fs/xfs/xfs_bio_io.c
@@ -26,11 +26,8 @@ xfs_rw_bdev(
if (is_vmalloc && op == REQ_OP_WRITE)
flush_kernel_vmap_range(data, count);

- bio = bio_alloc(GFP_KERNEL, bio_max_vecs(left));
- bio_set_dev(bio, bdev);
- bio->bi_iter.bi_sector = sector;
- bio->bi_opf = op | REQ_META | REQ_SYNC;
-
+ bio = bio_new(bdev, sector, op, REQ_META | REQ_SYNC, bio_max_vecs(left),
+ GFP_KERNEL);
do {
struct page *page = kmem_to_page(data);
unsigned int off = offset_in_page(data);
--
2.22.1

2021-01-28 17:25:54

by Darrick J. Wong

Subject: Re: [RFC PATCH 26/34] xfs: use bio_new in xfs_rw_bdev

On Wed, Jan 27, 2021 at 11:11:25PM -0800, Chaitanya Kulkarni wrote:
> Signed-off-by: Chaitanya Kulkarni <[email protected]>

Seems fine to me...
Reviewed-by: Darrick J. Wong <[email protected]>

--D

> ---
> fs/xfs/xfs_bio_io.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/fs/xfs/xfs_bio_io.c b/fs/xfs/xfs_bio_io.c
> index e2148f2d5d6b..e4644f22ebe6 100644
> --- a/fs/xfs/xfs_bio_io.c
> +++ b/fs/xfs/xfs_bio_io.c
> @@ -26,11 +26,8 @@ xfs_rw_bdev(
> if (is_vmalloc && op == REQ_OP_WRITE)
> flush_kernel_vmap_range(data, count);
>
> - bio = bio_alloc(GFP_KERNEL, bio_max_vecs(left));
> - bio_set_dev(bio, bdev);
> - bio->bi_iter.bi_sector = sector;
> - bio->bi_opf = op | REQ_META | REQ_SYNC;
> -
> + bio = bio_new(bdev, sector, op, REQ_META | REQ_SYNC, bio_max_vecs(left),
> + GFP_KERNEL);
> do {
> struct page *page = kmem_to_page(data);
> unsigned int off = offset_in_page(data);
> --
> 2.22.1
>