2021-02-04 01:21:35

by yebin (H)

Subject: [PATCH] usb: typec: remove unused variable ‘ret’ in typec_partner_set_pd_revis ion

Fix follow warning:
drivers/usb/typec/class.c:763:6: warning: unused variable ‘ret’ [-Wunused-variable]
int ret;
^~~

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Ye Bin <[email protected]>
---
drivers/usb/typec/class.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
index b6ceab3dc16b..1c2d50e016e2 100644
--- a/drivers/usb/typec/class.c
+++ b/drivers/usb/typec/class.c
@@ -760,8 +760,6 @@ EXPORT_SYMBOL_GPL(typec_partner_set_identity);
*/
int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision)
{
- int ret;
-
if (partner->pd_revision == pd_revision)
return 0;

--
2.25.4

2021-02-04 23:21:09

by Greg KH

Subject: Re: [PATCH] usb: typec: remove u nused variable ‘ret’ in typec_partner_set_pd_revision

On Thu, Feb 04, 2021 at 09:24:30AM +0800, Ye Bin wrote:
> Fix follow warning:
> drivers/usb/typec/class.c:763:6: warning: unused variable ‘ret’ [-Wunused-variable]
> int ret;
> ^~~
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Ye Bin <[email protected]>
> ---
> drivers/usb/typec/class.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index b6ceab3dc16b..1c2d50e016e2 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -760,8 +760,6 @@ EXPORT_SYMBOL_GPL(typec_partner_set_identity);
> */
> int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision)
> {
> - int ret;
> -
> if (partner->pd_revision == pd_revision)
> return 0;
>

This is already fixed in my tree, right? What did you make this
against?

thanks,

greg k-h