2021-02-05 12:39:10

by Bhaskar Chowdhury

[permalink] [raw]
Subject: [PATCH] fs: configfs: Fix sentence with a better word in the file symlink.c


s/fucking/wonderful/

Signed-off-by: Bhaskar Chowdhury <[email protected]>
---
fs/configfs/symlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/configfs/symlink.c b/fs/configfs/symlink.c
index cb61467478ca..26676e27346b 100644
--- a/fs/configfs/symlink.c
+++ b/fs/configfs/symlink.c
@@ -169,7 +169,7 @@ int configfs_symlink(struct inode *dir, struct dentry *dentry, const char *symna
* link(2) and symlink(2) - they wanted the target resolved
* at syscall time (as link(2) would've done), be a directory
* (which link(2) would've refused to do) *AND* be a deep
- * fucking magic, making the target busy from rmdir POV.
+ * wonderful magic, making the target busy from rmdir POV.
* symlink(2) is nothing of that sort, and the locking it
* gets matches the normal symlink(2) semantics. Without
* attempts to resolve the target (which might very well
--
2.30.0


2021-02-14 15:45:36

by Al Viro

[permalink] [raw]
Subject: Re: [PATCH] fs: configfs: Fix sentence with a better word in the file symlink.c

On Fri, Feb 05, 2021 at 06:02:35PM +0530, Bhaskar Chowdhury wrote:
>
> s/fucking/wonderful/

NAK. For one thing, your crusade (pardon the obscenity) is idiotic.
For another, in this particular case your attempt of improvement
changes the meaning to nearly opposite. "Magic" here is no
compliment - read the comment and try to understand what it says.

2021-02-15 01:42:48

by Bhaskar Chowdhury

[permalink] [raw]
Subject: Re: [PATCH] fs: configfs: Fix sentence with a better word in the file symlink.c

On 15:37 Sun 14 Feb 2021, Al Viro wrote:
>On Fri, Feb 05, 2021 at 06:02:35PM +0530, Bhaskar Chowdhury wrote:
>>
>> s/fucking/wonderful/
>
>NAK. For one thing, your crusade (pardon the obscenity) is idiotic.
>For another, in this particular case your attempt of improvement
>changes the meaning to nearly opposite. "Magic" here is no
>compliment - read the comment and try to understand what it says.


As expected Al, you are spot on. I will improve, honestly.

You haven't read my other mail ...it should be lying somewhere in you
inbox...that contain enough clue. :)

Thanks, man!


Attachments:
(No filename) (603.00 B)
signature.asc (499.00 B)
Download all attachments