2021-02-05 12:48:33

by Bhaskar Chowdhury

[permalink] [raw]
Subject: [PATCH] drivers: mtd: Better word replace a not so good word in the file mtd_blkdevs.c



s/fucking/invite/


Signed-off-by: Bhaskar Chowdhury <[email protected]>
---
drivers/mtd/mtd_blkdevs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index fb8e12d590a1..756a0995e474 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -523,7 +523,7 @@ int register_mtd_blktrans(struct mtd_blktrans_ops *tr)
int ret;

/* Register the notifier if/when the first device type is
- registered, to prevent the link/init ordering from fucking
+ registered, to prevent the link/init ordering from invite
us over. */
if (!blktrans_notifier.list.next)
register_mtd_user(&blktrans_notifier);
--
2.30.0


2021-02-05 13:50:13

by Miquel Raynal

[permalink] [raw]
Subject: Re: [PATCH] drivers: mtd: Better word replace a not so good word in the file mtd_blkdevs.c

Hi Bhaskar,

Bhaskar Chowdhury <[email protected]> wrote on Fri, 5 Feb 2021
18:11:51 +0530:

> s/fucking/invite/
>
>
> Signed-off-by: Bhaskar Chowdhury <[email protected]>
> ---
> drivers/mtd/mtd_blkdevs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
> index fb8e12d590a1..756a0995e474 100644
> --- a/drivers/mtd/mtd_blkdevs.c
> +++ b/drivers/mtd/mtd_blkdevs.c
> @@ -523,7 +523,7 @@ int register_mtd_blktrans(struct mtd_blktrans_ops *tr)
> int ret;
>
> /* Register the notifier if/when the first device type is
> - registered, to prevent the link/init ordering from fucking
> + registered, to prevent the link/init ordering from invite
> us over. */

invite us over?

I'm not a native English speaker but this does not bring any value to
my ears. Worse, I don't even get the point. Better rewrite the comment
entirely than just swapping "fucking" with a random word, no?

Thanks,
Miquèl

2021-02-05 14:02:34

by Miquel Raynal

[permalink] [raw]
Subject: Re: [PATCH] drivers: mtd: Better word replace a not so good word in the file mtd_blkdevs.c

Hi Bhaskar,

Bhaskar Chowdhury <[email protected]> wrote on Fri, 5 Feb 2021
19:06:39 +0530:

> On 14:26 Fri 05 Feb 2021, Miquel Raynal wrote:
> >Hi Bhaskar,
> >
> >Bhaskar Chowdhury <[email protected]> wrote on Fri, 5 Feb 2021
> >18:11:51 +0530:
> >
> >> s/fucking/invite/
> >>
> >>
> >> Signed-off-by: Bhaskar Chowdhury <[email protected]>
> >> ---
> >> drivers/mtd/mtd_blkdevs.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
> >> index fb8e12d590a1..756a0995e474 100644
> >> --- a/drivers/mtd/mtd_blkdevs.c
> >> +++ b/drivers/mtd/mtd_blkdevs.c
> >> @@ -523,7 +523,7 @@ int register_mtd_blktrans(struct mtd_blktrans_ops *t
> r)
> >> int ret;
> >>
> >> /* Register the notifier if/when the first device type is
> >> - registered, to prevent the link/init ordering from fucking
> >> + registered, to prevent the link/init ordering from invite
> >> us over. */
> >
> >invite us over?
> >
> >I'm not a native English speaker but this does not bring any value to
> >my ears. Worse, I don't even get the point. Better rewrite the comment
> >entirely than just swapping "fucking" with a random word, no?
> >
> Got your point , and I do understand "fuck" and "fucking" is so strong word
> that it is really difficult to replace with something else.
>
> But..but you suggestion to rewrite the comments sounds good Miquel ...wish I
> could have that much time in hand to replace every sentence having that word
> ...all the patched sent with that word replaces...please step forward and
> make
> and send patches .
>
> Today I sent 10 patches replacing that word(weather that make sense or not)
> you can see those in the ML ...please pick up as you wish and send patches.

There are currently 21 uses of "fuck[ing]". It's not a mountain to
climb. Nor a race.

> I was simply replacing the word ..never bother about the meaning it
> conveys..doesn't matter really.

Are you kidding? What is the purpose of a comment if no one understands
it after a blind change?

>
> so...
>

2021-02-05 23:56:34

by Bhaskar Chowdhury

[permalink] [raw]
Subject: Re: [PATCH] drivers: mtd: Better word replace a not so good word in the file mtd_blkdevs.c

On 14:57 Fri 05 Feb 2021, Miquel Raynal wrote:
>Hi Bhaskar,
>
>Bhaskar Chowdhury <[email protected]> wrote on Fri, 5 Feb 2021
>19:06:39 +0530:
>
>> On 14:26 Fri 05 Feb 2021, Miquel Raynal wrote:
>> >Hi Bhaskar,
>> >
>> >Bhaskar Chowdhury <[email protected]> wrote on Fri, 5 Feb 2021
>> >18:11:51 +0530:
>> >
>> >> s/fucking/invite/
>> >>
>> >>
>> >> Signed-off-by: Bhaskar Chowdhury <[email protected]>
>> >> ---
>> >> drivers/mtd/mtd_blkdevs.c | 2 +-
>> >> 1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
>> >> index fb8e12d590a1..756a0995e474 100644
>> >> --- a/drivers/mtd/mtd_blkdevs.c
>> >> +++ b/drivers/mtd/mtd_blkdevs.c
>> >> @@ -523,7 +523,7 @@ int register_mtd_blktrans(struct mtd_blktrans_ops *t
>> r)
>> >> int ret;
>> >>
>> >> /* Register the notifier if/when the first device type is
>> >> - registered, to prevent the link/init ordering from fucking
>> >> + registered, to prevent the link/init ordering from invite
>> >> us over. */
>> >
>> >invite us over?
>> >
>> >I'm not a native English speaker but this does not bring any value to
>> >my ears. Worse, I don't even get the point. Better rewrite the comment
>> >entirely than just swapping "fucking" with a random word, no?
>> >
>> Got your point , and I do understand "fuck" and "fucking" is so strong word
>> that it is really difficult to replace with something else.
>>
>> But..but you suggestion to rewrite the comments sounds good Miquel ...wish I
>> could have that much time in hand to replace every sentence having that word
>> ...all the patched sent with that word replaces...please step forward and
>> make
>> and send patches .
>>
>> Today I sent 10 patches replacing that word(weather that make sense or not)
>> you can see those in the ML ...please pick up as you wish and send patches.
>
>There are currently 21 uses of "fuck[ing]". It's not a mountain to
>climb. Nor a race.
>
✔ ~/git-linux/linux [master|✔]
19:28 $ search fuck | wc -l
15

>> I was simply replacing the word ..never bother about the meaning it
>> conveys..doesn't matter really.
>
>Are you kidding? What is the purpose of a comment if no one understands
>it after a blind change?
>
No I am not . But the sentences contains that word hardly have more meaning. But as you already said rewriting those comment would be a good idea...can you take up some of those??

>>
>> so...
>>


Attachments:
(No filename) (2.45 kB)
signature.asc (499.00 B)
Download all attachments

2021-02-06 00:03:07

by Richard Weinberger

[permalink] [raw]
Subject: Re: [PATCH] drivers: mtd: Better word replace a not so good word in the file mtd_blkdevs.c

----- Ursprüngliche Mail -----
> Von: "Bhaskar Chowdhury" <[email protected]>
> An: "Miquel Raynal" <[email protected]>
> CC: "richard" <[email protected]>, "Vignesh Raghavendra" <[email protected]>, "linux-mtd" <[email protected]>,
> "linux-kernel" <[email protected]>, "Randy Dunlap" <[email protected]>
> Gesendet: Freitag, 5. Februar 2021 14:36:39
> Betreff: Re: [PATCH] drivers: mtd: Better word replace a not so good word in the file mtd_blkdevs.c

> On 14:26 Fri 05 Feb 2021, Miquel Raynal wrote:
>>Hi Bhaskar,
>>
>>Bhaskar Chowdhury <[email protected]> wrote on Fri, 5 Feb 2021
>>18:11:51 +0530:
>>
>>> s/fucking/invite/

If you are afraid of "fucking", please replace it with "f*cking" or such.
"invite" makes no sense.

Thanks,
//richard

2021-02-06 00:03:25

by Bhaskar Chowdhury

[permalink] [raw]
Subject: Re: [PATCH] drivers: mtd: Better word replace a not so good word in the file mtd_blkdevs.c

On 14:49 Fri 05 Feb 2021, Richard Weinberger wrote:
>----- Ursprüngliche Mail -----
>> Von: "Bhaskar Chowdhury" <[email protected]>
>> An: "Miquel Raynal" <[email protected]>
>> CC: "richard" <[email protected]>, "Vignesh Raghavendra" <[email protected]>, "linux-mtd" <[email protected]>,
>> "linux-kernel" <[email protected]>, "Randy Dunlap" <[email protected]>
>> Gesendet: Freitag, 5. Februar 2021 14:36:39
>> Betreff: Re: [PATCH] drivers: mtd: Better word replace a not so good word in the file mtd_blkdevs.c
>
>> On 14:26 Fri 05 Feb 2021, Miquel Raynal wrote:
>>>Hi Bhaskar,
>>>
>>>Bhaskar Chowdhury <[email protected]> wrote on Fri, 5 Feb 2021
>>>18:11:51 +0530:
>>>
>>>> s/fucking/invite/
>
>If you are afraid of "fucking", please replace it with "f*cking" or such.
>"invite" makes no sense.
>
I am NOT afraid of anything ,just replacing the bad words ..that's all
...never bother to evaluate already bad sentences with correct word.

I know it is not make any sense ...still a better word ...
>Thanks,
>//richard


Attachments:
(No filename) (1.06 kB)
signature.asc (499.00 B)
Download all attachments

2021-02-06 00:07:12

by Bhaskar Chowdhury

[permalink] [raw]
Subject: Re: [PATCH] drivers: mtd: Better word replace a not so good word in the file mtd_blkdevs.c

On 14:26 Fri 05 Feb 2021, Miquel Raynal wrote:
>Hi Bhaskar,
>
>Bhaskar Chowdhury <[email protected]> wrote on Fri, 5 Feb 2021
>18:11:51 +0530:
>
>> s/fucking/invite/
>>
>>
>> Signed-off-by: Bhaskar Chowdhury <[email protected]>
>> ---
>> drivers/mtd/mtd_blkdevs.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
>> index fb8e12d590a1..756a0995e474 100644
>> --- a/drivers/mtd/mtd_blkdevs.c
>> +++ b/drivers/mtd/mtd_blkdevs.c
>> @@ -523,7 +523,7 @@ int register_mtd_blktrans(struct mtd_blktrans_ops *tr)
>> int ret;
>>
>> /* Register the notifier if/when the first device type is
>> - registered, to prevent the link/init ordering from fucking
>> + registered, to prevent the link/init ordering from invite
>> us over. */
>
>invite us over?
>
>I'm not a native English speaker but this does not bring any value to
>my ears. Worse, I don't even get the point. Better rewrite the comment
>entirely than just swapping "fucking" with a random word, no?
>
Got your point , and I do understand "fuck" and "fucking" is so strong word
that it is really difficult to replace with something else.

But..but you suggestion to rewrite the comments sounds good Miquel ...wish I
could have that much time in hand to replace every sentence having that word
...all the patched sent with that word replaces...please step forward and make
and send patches .

Today I sent 10 patches replacing that word(weather that make sense or not)
you can see those in the ML ...please pick up as you wish and send patches.

I was simply replacing the word ..never bother about the meaning it
conveys..doesn't matter really.

so...

Thanks.
>Thanks,
>Miquèl


Attachments:
(No filename) (1.74 kB)
signature.asc (499.00 B)
Download all attachments