2021-02-08 13:21:53

by Martin Kepplinger

Subject: [PATCH 0/5] arm64: dts: librem5 phone and devkit dts and config updates

Small updates to Purism hardware in order to maintain support:

Angus Ainslie (1):
arm64: dts: librem5: protect some partitions of the nor-flash

Guido Günther (3):
arm64: dts: imx8mq-librem5-devkit: Drop buck3 startup-ramp-delay
arm64: dts: librem5: Drop assigned-clocks from SAI2
arm64: defconfig: Enable devfreq support for i.MX8MQ

Martin Kepplinger (1):
arm64: dts: imx8mq-librem5-r2: set nearlevel to 120

.../dts/freescale/imx8mq-librem5-devkit.dts | 1 -
.../boot/dts/freescale/imx8mq-librem5-r2.dts | 2 +-
.../boot/dts/freescale/imx8mq-librem5.dtsi | 18 ++++++++++++++++--
arch/arm64/configs/defconfig | 2 ++
4 files changed, 19 insertions(+), 4 deletions(-)

--
2.20.1

2021-02-08 13:23:00

by Martin Kepplinger

Subject: [PATCH 4/5] arm64: dts: librem5: protect some partitions of the nor-flash

From: Angus Ainslie <[email protected]>

These sections should be read only as they contain important data.

Signed-off-by: Angus Ainslie <[email protected]>
Signed-off-by: Martin Kepplinger <[email protected]>
---
.../arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index c2bbbdeb93e3..9867e2a50008 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -258,6 +258,22 @@
compatible = "jedec,spi-nor";
reg = <0>;
spi-max-frequency = <1000000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ partition@0x00000000 {
+ label = "protected0";
+ reg = <0x00000000 0x00030000>;
+ read-only;
+ };
+ partition@0x00030000 {
+ label = "protected1";
+ reg = <0x00030000 0x00010000>;
+ read-only;
+ };
+ partition@0x00040000 {
+ label = "rw";
+ reg = <0x00040000 0x001C0000>;
+ };
};
};

--
2.20.1

2021-02-08 13:23:37

by Martin Kepplinger

Subject: [PATCH 5/5] arm64: dts: imx8mq-librem5-r2: set nearlevel to 120

On Birch I can never reach 220 and hence the display would never
turn off. Tests suggest 120 to be a good threshold value for all Birch
devices.

Signed-off-by: Martin Kepplinger <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts
index d77fc5df3f06..73bd431cbd6a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts
@@ -25,5 +25,5 @@
};

&proximity {
- proximity-near-level = <220>;
+ proximity-near-level = <120>;
};
--
2.20.1

2021-02-08 14:40:05

by Krzysztof Kozlowski

Subject: Re: [PATCH 4/5] arm64: dts: librem5: protect some partitions of the nor-flash

On Mon, Feb 08, 2021 at 02:15:26PM +0100, Martin Kepplinger wrote:
> From: Angus Ainslie <[email protected]>
>
> These sections should be read only as they contain important data.
>
> Signed-off-by: Angus Ainslie <[email protected]>
> Signed-off-by: Martin Kepplinger <[email protected]>
> ---
> .../arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index c2bbbdeb93e3..9867e2a50008 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -258,6 +258,22 @@
> compatible = "jedec,spi-nor";
> reg = <0>;
> spi-max-frequency = <1000000>;
> + #address-cells = <1>;
> + #size-cells = <1>;

One empty line here.

> + partition@0x00000000 {

Wrong unit names. Compile dtses with W=1.

> + label = "protected0";
> + reg = <0x00000000 0x00030000>;

Get rid of leading 0000 - it makes it less readable.

Best regards,
Krzysztof