2021-02-19 18:27:58

by Kurt Manucredo

Subject: [PATCH v3] staging: rtl8723bs: fix code style comparison warning

checkpatch gives the following WARNING:
WARNING: Comparisons should place the constant on the right side of the test
this patch fixes the coding style warning.

Signed-off-by: Kurt Manucredo <[email protected]>
---

changes since previous version:
- put version chatter below the --- cut off line.

thank you very much for your help Mr. Dan Carpenter.

drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 975f2830e29e..96feced698ac 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcur_dot11txpn, u8 *StaAddr)
struct security_priv *psecpriv = &padapter->securitypriv;

memset(pcur_dot11txpn, 0, 8);
- if (NULL == StaAddr)
+ if (!StaAddr)
return;
psta = rtw_get_stainfo(&padapter->stapriv, StaAddr);
DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n",
--
2.20.1

2021-02-22 05:10:40

by Dan Carpenter

Subject: Re: [PATCH v3] staging: rtl8723bs: fix code style comparison warning

On Fri, Feb 19, 2021 at 06:23:54PM +0000, Kurt Manucredo wrote:
>
>
> checkpatch gives the following WARNING:
> WARNING: Comparisons should place the constant on the right side of the test
> this patch fixes the coding style warning.
>
> Signed-off-by: Kurt Manucredo <[email protected]>
> ---

Looks okay to me. Thanks!

Reviewed-by: Dan Carpenter <[email protected]>

regards,
dan carpenter