LinuxLists.cc - [PATCH 1/1] vsprintf: dump full information of page flags in pGp fix

2021-02-23 05:56:10

Subject: [PATCH 1/1] vsprintf: dump full information of page flags in pGp fix

The name of the flag should be printed using default_str_spec.
There's no difference in the output after this change because the string is
printed as-is with both default_dec_spec and default_flag_spec.

This patch is a followup of the patchset
"mm, vsprintf: dump full information of page flags in pGp" [1]

[1]. https://lore.kernel.org/linux-mm/[email protected]/
Signed-off-by: Yafang Shao <[email protected]>
Cc: Petr Mladek <[email protected]>
Cc: Matthew Wilcox <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: Vlastimil Babka <[email protected]>
Cc: Miaohe Lin <[email protected]>
Cc: Joe Perches <[email protected]>
Cc: David Hildenbrand <[email protected]>
---
lib/vsprintf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 533ac5404180..5d034e799c06 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1963,7 +1963,7 @@ char *format_page_flags(char *buf, char *end, unsigned long flags)
buf++;
}

- buf = string(buf, end, p->name, *p->spec);
+ buf = string(buf, end, p->name, default_str_spec);
if (buf < end)
*buf = '=';
buf++;
--
2.17.1

2021-02-23 14:58:16

by Petr Mladek

[permalink] [raw]

Subject: Re: [PATCH 1/1] vsprintf: dump full information of page flags in pGp fix

On Tue 2021-02-23 13:51:24, Yafang Shao wrote:
> The name of the flag should be printed using default_str_spec.
> There's no difference in the output after this change because the string is
> printed as-is with both default_dec_spec and default_flag_spec.
>
> This patch is a followup of the patchset
> "mm, vsprintf: dump full information of page flags in pGp" [1]
>
> [1]. https://lore.kernel.org/linux-mm/[email protected]/
> Signed-off-by: Yafang Shao <[email protected]>
> Cc: Petr Mladek <[email protected]>
> Cc: Matthew Wilcox <[email protected]>
> Cc: Andy Shevchenko <[email protected]>
> Cc: Vlastimil Babka <[email protected]>
> Cc: Miaohe Lin <[email protected]>
> Cc: Joe Perches <[email protected]>
> Cc: David Hildenbrand <[email protected]>

Reviewed-by: Petr Mladek <[email protected]>

Best Regards,
Petr

2021-03-09 10:26:48

by Petr Mladek

[permalink] [raw]