2021-02-22 05:08:23

by Florian Fainelli

Subject: Re: [PATCH net] bcm63xx_enet: fix sporadic kernel panic

On 2/21/2021 17:35, Sieng Piaw Liew wrote:
> In ndo_stop functions, netdev_completed_queue() is called during forced
> tx reclaim, after netdev_reset_queue(). This may trigger kernel panic if
> there is any tx skb left.
>
> This patch moves netdev_reset_queue() to after tx reclaim, so BQL can
> complete successfully then reset.
>
> Signed-off-by: Sieng Piaw Liew <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
Fixes: 4c59b0f5543d ("bcm63xx_enet: add BQL support")
--
Florian

2021-02-23 21:07:29

by Jakub Kicinski

Subject: Re: [PATCH net] bcm63xx_enet: fix sporadic kernel panic

On Sun, 21 Feb 2021 21:05:50 -0800 Florian Fainelli wrote:
> On 2/21/2021 17:35, Sieng Piaw Liew wrote:
> > In ndo_stop functions, netdev_completed_queue() is called during forced
> > tx reclaim, after netdev_reset_queue(). This may trigger kernel panic if
> > there is any tx skb left.
> >
> > This patch moves netdev_reset_queue() to after tx reclaim, so BQL can
> > complete successfully then reset.
> >
> > Signed-off-by: Sieng Piaw Liew <[email protected]>
>
> Acked-by: Florian Fainelli <[email protected]>
> Fixes: 4c59b0f5543d ("bcm63xx_enet: add BQL support")

Applied, thanks!