2021-02-22 01:45:04

by Sieng-Piaw Liew

[permalink] [raw]
Subject: [PATCH net] atl1c: switch to napi_gro_receive

Changing to napi_gro_receive() improves efficiency significantly. Tested
on Intel Core2-based motherboards and iperf3.

Signed-off-by: Sieng Piaw Liew <[email protected]>
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index 3f65f2b370c5..3e440c2dc68a 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -1851,7 +1851,7 @@ static void atl1c_clean_rx_irq(struct atl1c_adapter *adapter,
vlan = le16_to_cpu(vlan);
__vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), vlan);
}
- netif_receive_skb(skb);
+ napi_gro_receive(&adapter->napi, skb);

(*work_done)++;
count++;
--
2.17.1


2021-02-24 01:09:49

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH net] atl1c: switch to napi_gro_receive

On Mon, 22 Feb 2021 09:40:45 +0800 Sieng Piaw Liew wrote:
> Changing to napi_gro_receive() improves efficiency significantly. Tested
> on Intel Core2-based motherboards and iperf3.
>
> Signed-off-by: Sieng Piaw Liew <[email protected]>

net-next is currently closed (see the note below). Would you mind
resending this change in a week or two?


# Form letter - net-next is closed

We have already sent the networking pull request for 5.12 and therefore
net-next is closed for new drivers, features, code refactoring and
optimizations. We are currently accepting bug fixes only.

Please repost when net-next reopens after 5.12-rc1 is cut.

Look out for the announcement on the mailing list or check:
http://vger.kernel.org/~davem/net-next.html

RFC patches sent for review only are obviously welcome at any time.