2021-02-24 15:32:39

by Daniel Lezcano

Subject: [PATCH v2 6/9] iio/drivers/hid-sensor: Use HZ macros

HZ unit conversion macros are available in units.h, use them and
remove the duplicate definition.

Signed-off-by: Daniel Lezcano <[email protected]>
---
drivers/iio/common/hid-sensors/hid-sensor-attributes.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
index 442ff787f7af..dda3b67e494f 100644
--- a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
+++ b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
@@ -11,13 +11,12 @@
#include <linux/kernel.h>
#include <linux/slab.h>
#include <linux/time.h>
+#include <linux/units.h>

#include <linux/hid-sensor-hub.h>
#include <linux/iio/iio.h>
#include <linux/iio/sysfs.h>

-#define HZ_PER_MHZ 1000000L
-
static struct {
u32 usage_id;
int unit; /* 0 for default others from HID sensor spec */
--
2.17.1

2021-03-14 17:02:35

by Jonathan Cameron

Subject: Re: [PATCH v2 6/9] iio/drivers/hid-sensor: Use HZ macros

On Wed, 24 Feb 2021 15:42:16 +0100
Daniel Lezcano <[email protected]> wrote:

> HZ unit conversion macros are available in units.h, use them and
> remove the duplicate definition.
>
> Signed-off-by: Daniel Lezcano <[email protected]>
Acked-by: Jonathan Cameron <[email protected]>

> ---
> drivers/iio/common/hid-sensors/hid-sensor-attributes.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> index 442ff787f7af..dda3b67e494f 100644
> --- a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> +++ b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> @@ -11,13 +11,12 @@
> #include <linux/kernel.h>
> #include <linux/slab.h>
> #include <linux/time.h>
> +#include <linux/units.h>
>
> #include <linux/hid-sensor-hub.h>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
>
> -#define HZ_PER_MHZ 1000000L
> -
> static struct {
> u32 usage_id;
> int unit; /* 0 for default others from HID sensor spec */