2021-02-15 15:17:28

by Maheep Kumar Kathuria

Subject: [PATCH] btrfs: Fixed a brace coding style issue

Fixed a coding style issue in thresh_exec_hook()

Signed-off-by: Maheep Kumar Kathuria <[email protected]>
---
fs/btrfs/async-thread.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/btrfs/async-thread.c b/fs/btrfs/async-thread.c
index 309516e6a968..38abeff7af69 100644
--- a/fs/btrfs/async-thread.c
+++ b/fs/btrfs/async-thread.c
@@ -212,9 +212,8 @@ static inline void thresh_exec_hook(struct __btrfs_workqueue *wq)
out:
spin_unlock(&wq->thres_lock);

- if (need_change) {
+ if (need_change)
workqueue_set_max_active(wq->normal_wq, wq->current_active);
- }
}

static void run_ordered_work(struct __btrfs_workqueue *wq,
--
2.29.2

2021-02-25 03:11:37

by David Sterba

Subject: Re: [PATCH] btrfs: Fixed a brace coding style issue

On Mon, Feb 15, 2021 at 08:38:20PM +0530, Maheep Kumar Kathuria wrote:
> Fixed a coding style issue in thresh_exec_hook()
>
> Signed-off-by: Maheep Kumar Kathuria <[email protected]>
> ---
> fs/btrfs/async-thread.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/async-thread.c b/fs/btrfs/async-thread.c
> index 309516e6a968..38abeff7af69 100644
> --- a/fs/btrfs/async-thread.c
> +++ b/fs/btrfs/async-thread.c
> @@ -212,9 +212,8 @@ static inline void thresh_exec_hook(struct __btrfs_workqueue *wq)
> out:
> spin_unlock(&wq->thres_lock);
>
> - if (need_change) {
> + if (need_change)
> workqueue_set_max_active(wq->normal_wq, wq->current_active);
> - }

This is really a trivial change, have you checked if there are more?
Fixing them in a larger batch would be better than one by one.