2021-03-04 08:37:59

by Wei Yongjun

Subject: [PATCH -next] afs: Remove unused variable in afs_req_issue_op()

GCC reports the following warning with W=1:

fs/afs/file.c:291:6: warning:
unused variable 'ret' [-Wunused-variable]
291 | int ret;
| ^~~

After commit 799fbdf96cd51, this variable is not used in function
afs_req_issue_op(), so this commit remove it to fix the warning.

Fixes: 799fbdf96cd51 ("afs: Use new fscache read helper API")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wei Yongjun <[email protected]>
---
fs/afs/file.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/afs/file.c b/fs/afs/file.c
index af162d7dab5b..cf2b664a68a5 100644
--- a/fs/afs/file.c
+++ b/fs/afs/file.c
@@ -288,7 +288,6 @@ static void afs_req_issue_op(struct netfs_read_subrequest *subreq)
{
struct afs_vnode *vnode = AFS_FS_I(subreq->rreq->inode);
struct afs_read *fsreq;
- int ret;

fsreq = afs_alloc_read(GFP_NOFS);
if (!fsreq)

2021-03-04 21:48:49

by David Howells

Subject: Re: [PATCH -next] afs: Remove unused variable in afs_req_issue_op()

Wei Yongjun <[email protected]> wrote:

> GCC reports the following warning with W=1:
>
> fs/afs/file.c:291:6: warning:
> unused variable 'ret' [-Wunused-variable]
> 291 | int ret;
> | ^~~
>
> After commit 799fbdf96cd51, this variable is not used in function
> afs_req_issue_op(), so this commit remove it to fix the warning.
>
> Fixes: 799fbdf96cd51 ("afs: Use new fscache read helper API")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Wei Yongjun <[email protected]>

I've already fixed that and updated my branch, thanks. linux-next should pick
it up on the next merging.

David