2021-03-05 07:34:39

by Gustavo A. R. Silva

Subject: [PATCH][next] net: mscc: ocelot: Fix fall-through warnings for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of just letting the code
fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <[email protected]>
Reviewed-by: Vladimir Oltean <[email protected]>
---
drivers/net/ethernet/mscc/ocelot_vcap.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/mscc/ocelot_vcap.c b/drivers/net/ethernet/mscc/ocelot_vcap.c
index 37a232911395..7945393a0655 100644
--- a/drivers/net/ethernet/mscc/ocelot_vcap.c
+++ b/drivers/net/ethernet/mscc/ocelot_vcap.c
@@ -761,6 +761,7 @@ static void is1_entry_set(struct ocelot *ocelot, int ix,
vcap_key_bytes_set(vcap, &data, VCAP_IS1_HK_ETYPE,
etype.value, etype.mask);
}
+ break;
}
default:
break;
--
2.27.0

2021-03-05 20:52:18

by David Miller

Subject: Re: [PATCH][next] net: mscc: ocelot: Fix fall-through warnings for Clang

Please resubmit these again when net-next opens back up, thank you.

2021-03-05 22:39:28

by Gustavo A. R. Silva

Subject: Re: [PATCH][next] net: mscc: ocelot: Fix fall-through warnings for Clang

On Fri, Mar 05, 2021 at 12:48:12PM -0800, David Miller wrote:
>
> Please resubmit these again when net-next opens back up, thank you.

Sure thing.

Thanks
--
Gustavo