2021-03-05 03:45:36

by Wei Yongjun

Subject: [PATCH -next] phy: ingenic: Fix a typo in ingenic_usb_phy_probe()

From: Wei Yongjun <[email protected]>

Fix the return value check typo which testing the wrong variable
in ingenic_usb_phy_probe().

Fixes: 31de313dfdcf ("PHY: Ingenic: Add USB PHY driver using generic PHY framework.")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/phy/ingenic/phy-ingenic-usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/ingenic/phy-ingenic-usb.c b/drivers/phy/ingenic/phy-ingenic-usb.c
index ea127b177f46..28c28d816484 100644
--- a/drivers/phy/ingenic/phy-ingenic-usb.c
+++ b/drivers/phy/ingenic/phy-ingenic-usb.c
@@ -352,8 +352,8 @@ static int ingenic_usb_phy_probe(struct platform_device *pdev)
}

priv->phy = devm_phy_create(dev, NULL, &ingenic_usb_phy_ops);
- if (IS_ERR(priv))
- return PTR_ERR(priv);
+ if (IS_ERR(priv->phy))
+ return PTR_ERR(priv->phy);

phy_set_drvdata(priv->phy, priv);

2021-03-08 02:36:12

by Paul Cercueil

Subject: Re: [PATCH -next] phy: ingenic: Fix a typo in ingenic_usb_phy_probe()

Le ven. 5 mars 2021 ? 3:49, 'Wei Yongjun <[email protected]> a
?crit :
> From: Wei Yongjun <[email protected]>
>
> Fix the return value check typo which testing the wrong variable
> in ingenic_usb_phy_probe().
>
> Fixes: 31de313dfdcf ("PHY: Ingenic: Add USB PHY driver using generic
> PHY framework.")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Wei Yongjun <[email protected]>

Acked-by: Paul Cercueil <[email protected]>

Cheers,
-Paul

> ---
> drivers/phy/ingenic/phy-ingenic-usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/ingenic/phy-ingenic-usb.c
> b/drivers/phy/ingenic/phy-ingenic-usb.c
> index ea127b177f46..28c28d816484 100644
> --- a/drivers/phy/ingenic/phy-ingenic-usb.c
> +++ b/drivers/phy/ingenic/phy-ingenic-usb.c
> @@ -352,8 +352,8 @@ static int ingenic_usb_phy_probe(struct
> platform_device *pdev)
> }
>
> priv->phy = devm_phy_create(dev, NULL, &ingenic_usb_phy_ops);
> - if (IS_ERR(priv))
> - return PTR_ERR(priv);
> + if (IS_ERR(priv->phy))
> + return PTR_ERR(priv->phy);
>
> phy_set_drvdata(priv->phy, priv);
>
>

2021-03-15 10:33:14

by Vinod Koul

Subject: Re: [PATCH -next] phy: ingenic: Fix a typo in ingenic_usb_phy_probe()

On 05-03-21, 03:49, 'Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> Fix the return value check typo which testing the wrong variable
> in ingenic_usb_phy_probe().

Applied, thanks

--
~Vinod