2021-03-08 12:30:14

by Wei Yongjun

Subject: [PATCH -next] coresight: etm: perf: Make symbol 'format_attr_contextid' static

From: Wei Yongjun <[email protected]>

The sparse tool complains as follows:



drivers/hwtracing/coresight/coresight-etm-perf.c:61:25: warning:

symbol 'format_attr_contextid' was not declared. Should it be static?



This symbol is not used outside of coresight-etm-perf.c, so this

commit marks it static.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
index 0f603b4094f2..bdbb77334329 100644
--- a/drivers/hwtracing/coresight/coresight-etm-perf.c
+++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
@@ -58,7 +58,7 @@ static ssize_t format_attr_contextid_show(struct device *dev,
return sprintf(page, "config:%d\n", pid_fmt);
}

-struct device_attribute format_attr_contextid =
+static struct device_attribute format_attr_contextid =
__ATTR(contextid, 0444, format_attr_contextid_show, NULL);

static struct attribute *etm_config_formats_attr[] = {

2021-03-08 12:33:23

by Suzuki K Poulose

Subject: Re: [PATCH -next] coresight: etm: perf: Make symbol 'format_attr_contextid' static

On 3/8/21 12:32 PM, 'Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> The sparse tool complains as follows:
>
> drivers/hwtracing/coresight/coresight-etm-perf.c:61:25: warning:
> symbol 'format_attr_contextid' was not declared. Should it be static?
>
> This symbol is not used outside of coresight-etm-perf.c, so this
> commit marks it static.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Wei Yongjun <[email protected]>

Reviewed-by: Suzuki K Poulose <[email protected]>