2021-03-11 06:44:17

by Hao Peng

Subject: [PATCH] staging: rtl8723bs: add initial value

Add initial value for some uninitialized variable and array.

Signed-off-by: Hao Peng <[email protected]>
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index b6f944b37b08..ceea160db38a 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -206,8 +206,8 @@ void expire_timeout_chk(struct adapter *padapter)
struct sta_info *psta = NULL;
struct sta_priv *pstapriv = &padapter->stapriv;
u8 chk_alive_num = 0;
- char chk_alive_list[NUM_STA];
- int i;
+ char chk_alive_list[NUM_STA] = {0};
+ int i = 0;

spin_lock_bh(&pstapriv->auth_list_lock);

@@ -308,7 +308,7 @@ void expire_timeout_chk(struct adapter *padapter)
}
}
if (pmlmeext->active_keep_alive_check) {
- int stainfo_offset;
+ int stainfo_offset = 0;

stainfo_offset = rtw_stainfo_offset(pstapriv, psta);
if (stainfo_offset_valid(stainfo_offset))
--
2.20.1

2021-03-12 10:04:39

by Dan Carpenter

Subject: Re: [PATCH] staging: rtl8723bs: add initial value

On Thu, Mar 11, 2021 at 02:38:38PM +0800, Hao Peng wrote:
> Add initial value for some uninitialized variable and array.
>

None of these are ever used uninitialized. It's weird that you would
even think that.

> if (pmlmeext->active_keep_alive_check) {
> - int stainfo_offset;
> + int stainfo_offset = 0;
>
> stainfo_offset = rtw_stainfo_offset(pstapriv, psta);
^^^^^^^^^^^^^^^^
This one is initialized on the very next line so all the patch does is
introduce static checker warnings for no reason.

regards,
dan carpenter