2021-03-16 20:27:32

by Geert Uytterhoeven

Subject: [PATCH] net: broadcom: BCM4908_ENET should not default to y, unconditionally

Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
To fix this, drop the automatic enabling of BCM4908_ENET.

Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 controller driver")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
Feel free to change to "default y if ARCH_BCM4908" and

To fix this, restrict the automatic enabling of BCM4908_ENET to
ARCH_BCM4908.

if you think BCM4908 SoCs cannot be used without enabling this.
---
drivers/net/ethernet/broadcom/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
index f8a168b73307c03b..57bac60ba2b190d2 100644
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -54,7 +54,6 @@ config B44_PCI
config BCM4908_ENET
tristate "Broadcom BCM4908 internal mac support"
depends on ARCH_BCM4908 || COMPILE_TEST
- default y
help
This driver supports Ethernet controller integrated into Broadcom
BCM4908 family SoCs.
--
2.25.1

2021-03-16 20:37:22

by Rafał Miłecki

Subject: Re: [PATCH] net: broadcom: BCM4908_ENET should not default to y, unconditionally

On 2021-03-16 14:38, Geert Uytterhoeven wrote:
> Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
> To fix this, drop the automatic enabling of BCM4908_ENET.
>
> Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908
> controller driver")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> Feel free to change to "default y if ARCH_BCM4908" and
>
> To fix this, restrict the automatic enabling of BCM4908_ENET to
> ARCH_BCM4908.
>
> if you think BCM4908 SoCs cannot be used without enabling this.

Yes, please make it
default y if ARCH_BCM4908
instead.