Hi Linus,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 8b12a62a4e3ed4ae99c715034f557eb391d6b196
commit: de8860b1ed4701ea7e6f760f02d79ca6a3b656a1 iio: magnetometer: Add driver for Yamaha YAS530
date: 10 weeks ago
config: m68k-randconfig-s032-20210318 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-277-gc089cd2d-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=de8860b1ed4701ea7e6f760f02d79ca6a3b656a1
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout de8860b1ed4701ea7e6f760f02d79ca6a3b656a1
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
In file included from include/linux/build_bug.h:5,
from include/linux/bitfield.h:10,
from drivers/iio/magnetometer/yamaha-yas530.c:22:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_no.h:33:50: warning: ordered comparison of pointer with null pointer [-Wextra]
33 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
In file included from drivers/iio/magnetometer/yamaha-yas530.c:35:
include/linux/unaligned/be_byteshift.h: At top level:
include/linux/unaligned/be_byteshift.h:41:19: error: redefinition of 'get_unaligned_be16'
41 | static inline u16 get_unaligned_be16(const void *p)
| ^~~~~~~~~~~~~~~~~~
In file included from arch/m68k/include/asm/unaligned.h:18,
from include/asm-generic/uaccess.h:13,
from arch/m68k/include/asm/uaccess.h:394,
from include/linux/uaccess.h:11,
from include/linux/sched/task.h:11,
from include/linux/sched/signal.h:9,
from include/linux/rcuwait.h:6,
from include/linux/percpu-rwsem.h:7,
from include/linux/fs.h:33,
from include/linux/cgroup.h:17,
from include/linux/memcontrol.h:13,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from include/linux/regulator/consumer.h:35,
from drivers/iio/magnetometer/yamaha-yas530.c:33:
include/linux/unaligned/access_ok.h:23:28: note: previous definition of 'get_unaligned_be16' was here
23 | static __always_inline u16 get_unaligned_be16(const void *p)
| ^~~~~~~~~~~~~~~~~~
In file included from drivers/iio/magnetometer/yamaha-yas530.c:35:
>> include/linux/unaligned/be_byteshift.h:46:19: error: redefinition of 'get_unaligned_be32'
46 | static inline u32 get_unaligned_be32(const void *p)
| ^~~~~~~~~~~~~~~~~~
In file included from arch/m68k/include/asm/unaligned.h:18,
from include/asm-generic/uaccess.h:13,
from arch/m68k/include/asm/uaccess.h:394,
from include/linux/uaccess.h:11,
from include/linux/sched/task.h:11,
from include/linux/sched/signal.h:9,
from include/linux/rcuwait.h:6,
from include/linux/percpu-rwsem.h:7,
from include/linux/fs.h:33,
from include/linux/cgroup.h:17,
from include/linux/memcontrol.h:13,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from include/linux/regulator/consumer.h:35,
from drivers/iio/magnetometer/yamaha-yas530.c:33:
include/linux/unaligned/access_ok.h:28:28: note: previous definition of 'get_unaligned_be32' was here
28 | static __always_inline u32 get_unaligned_be32(const void *p)
| ^~~~~~~~~~~~~~~~~~
In file included from drivers/iio/magnetometer/yamaha-yas530.c:35:
include/linux/unaligned/be_byteshift.h:51:19: error: redefinition of 'get_unaligned_be64'
51 | static inline u64 get_unaligned_be64(const void *p)
| ^~~~~~~~~~~~~~~~~~
In file included from arch/m68k/include/asm/unaligned.h:18,
from include/asm-generic/uaccess.h:13,
from arch/m68k/include/asm/uaccess.h:394,
from include/linux/uaccess.h:11,
from include/linux/sched/task.h:11,
from include/linux/sched/signal.h:9,
from include/linux/rcuwait.h:6,
from include/linux/percpu-rwsem.h:7,
from include/linux/fs.h:33,
from include/linux/cgroup.h:17,
from include/linux/memcontrol.h:13,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from include/linux/regulator/consumer.h:35,
from drivers/iio/magnetometer/yamaha-yas530.c:33:
include/linux/unaligned/access_ok.h:33:28: note: previous definition of 'get_unaligned_be64' was here
33 | static __always_inline u64 get_unaligned_be64(const void *p)
| ^~~~~~~~~~~~~~~~~~
In file included from drivers/iio/magnetometer/yamaha-yas530.c:35:
include/linux/unaligned/be_byteshift.h:56:20: error: redefinition of 'put_unaligned_be16'
56 | static inline void put_unaligned_be16(u16 val, void *p)
| ^~~~~~~~~~~~~~~~~~
In file included from arch/m68k/include/asm/unaligned.h:18,
from include/asm-generic/uaccess.h:13,
from arch/m68k/include/asm/uaccess.h:394,
from include/linux/uaccess.h:11,
from include/linux/sched/task.h:11,
from include/linux/sched/signal.h:9,
from include/linux/rcuwait.h:6,
from include/linux/percpu-rwsem.h:7,
from include/linux/fs.h:33,
from include/linux/cgroup.h:17,
from include/linux/memcontrol.h:13,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from include/linux/regulator/consumer.h:35,
from drivers/iio/magnetometer/yamaha-yas530.c:33:
include/linux/unaligned/access_ok.h:53:29: note: previous definition of 'put_unaligned_be16' was here
53 | static __always_inline void put_unaligned_be16(u16 val, void *p)
| ^~~~~~~~~~~~~~~~~~
In file included from drivers/iio/magnetometer/yamaha-yas530.c:35:
>> include/linux/unaligned/be_byteshift.h:61:20: error: redefinition of 'put_unaligned_be32'
61 | static inline void put_unaligned_be32(u32 val, void *p)
| ^~~~~~~~~~~~~~~~~~
In file included from arch/m68k/include/asm/unaligned.h:18,
from include/asm-generic/uaccess.h:13,
from arch/m68k/include/asm/uaccess.h:394,
from include/linux/uaccess.h:11,
from include/linux/sched/task.h:11,
from include/linux/sched/signal.h:9,
from include/linux/rcuwait.h:6,
from include/linux/percpu-rwsem.h:7,
from include/linux/fs.h:33,
from include/linux/cgroup.h:17,
from include/linux/memcontrol.h:13,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from include/linux/regulator/consumer.h:35,
from drivers/iio/magnetometer/yamaha-yas530.c:33:
include/linux/unaligned/access_ok.h:58:29: note: previous definition of 'put_unaligned_be32' was here
58 | static __always_inline void put_unaligned_be32(u32 val, void *p)
| ^~~~~~~~~~~~~~~~~~
In file included from drivers/iio/magnetometer/yamaha-yas530.c:35:
include/linux/unaligned/be_byteshift.h:66:20: error: redefinition of 'put_unaligned_be64'
66 | static inline void put_unaligned_be64(u64 val, void *p)
| ^~~~~~~~~~~~~~~~~~
In file included from arch/m68k/include/asm/unaligned.h:18,
from include/asm-generic/uaccess.h:13,
from arch/m68k/include/asm/uaccess.h:394,
from include/linux/uaccess.h:11,
from include/linux/sched/task.h:11,
from include/linux/sched/signal.h:9,
from include/linux/rcuwait.h:6,
from include/linux/percpu-rwsem.h:7,
from include/linux/fs.h:33,
from include/linux/cgroup.h:17,
from include/linux/memcontrol.h:13,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from include/linux/regulator/consumer.h:35,
from drivers/iio/magnetometer/yamaha-yas530.c:33:
include/linux/unaligned/access_ok.h:63:29: note: previous definition of 'put_unaligned_be64' was here
63 | static __always_inline void put_unaligned_be64(u64 val, void *p)
| ^~~~~~~~~~~~~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
Selected by
- SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
- SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC
vim +/get_unaligned_be32 +46 include/linux/unaligned/be_byteshift.h
064106a91be5e7 Harvey Harrison 2008-04-29 45
064106a91be5e7 Harvey Harrison 2008-04-29 @46 static inline u32 get_unaligned_be32(const void *p)
064106a91be5e7 Harvey Harrison 2008-04-29 47 {
19f747f7370fcf Bart Van Assche 2020-03-13 48 return __get_unaligned_be32(p);
064106a91be5e7 Harvey Harrison 2008-04-29 49 }
064106a91be5e7 Harvey Harrison 2008-04-29 50
064106a91be5e7 Harvey Harrison 2008-04-29 51 static inline u64 get_unaligned_be64(const void *p)
064106a91be5e7 Harvey Harrison 2008-04-29 52 {
19f747f7370fcf Bart Van Assche 2020-03-13 53 return __get_unaligned_be64(p);
064106a91be5e7 Harvey Harrison 2008-04-29 54 }
064106a91be5e7 Harvey Harrison 2008-04-29 55
064106a91be5e7 Harvey Harrison 2008-04-29 56 static inline void put_unaligned_be16(u16 val, void *p)
064106a91be5e7 Harvey Harrison 2008-04-29 57 {
064106a91be5e7 Harvey Harrison 2008-04-29 58 __put_unaligned_be16(val, p);
064106a91be5e7 Harvey Harrison 2008-04-29 59 }
064106a91be5e7 Harvey Harrison 2008-04-29 60
064106a91be5e7 Harvey Harrison 2008-04-29 @61 static inline void put_unaligned_be32(u32 val, void *p)
064106a91be5e7 Harvey Harrison 2008-04-29 62 {
064106a91be5e7 Harvey Harrison 2008-04-29 63 __put_unaligned_be32(val, p);
064106a91be5e7 Harvey Harrison 2008-04-29 64 }
064106a91be5e7 Harvey Harrison 2008-04-29 65
:::::: The code at line 46 was first introduced by commit
:::::: 064106a91be5e76cb42c1ddf5d3871e3a1bd2a23 kernel: add common infrastructure for unaligned access
:::::: TO: Harvey Harrison <[email protected]>
:::::: CC: Linus Torvalds <[email protected]>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
On Fri, Mar 19, 2021 at 9:05 AM kernel test robot <[email protected]> wrote:
>
> Hi Linus,
>
> FYI, the error/warning still remains.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 8b12a62a4e3ed4ae99c715034f557eb391d6b196
> commit: de8860b1ed4701ea7e6f760f02d79ca6a3b656a1 iio: magnetometer: Add driver for Yamaha YAS530
> date: 10 weeks ago
> config: m68k-randconfig-s032-20210318 (attached as .config)
> compiler: m68k-linux-gcc (GCC) 9.3.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # apt-get install sparse
> # sparse version: v0.6.3-277-gc089cd2d-dirty
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=de8860b1ed4701ea7e6f760f02d79ca6a3b656a1
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout de8860b1ed4701ea7e6f760f02d79ca6a3b656a1
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=m68k
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/build_bug.h:5,
> from include/linux/bitfield.h:10,
> from drivers/iio/magnetometer/yamaha-yas530.c:22:
Isn't it fixed already somewhere?
...
> Kconfig warnings: (for reference only)
> WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
> Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
> Selected by
> - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
> - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC
This one though is interesting.
Cc Takashi and Mark.
--
With Best Regards,
Andy Shevchenko
On Fri, Mar 19, 2021 at 10:57 AM Andy Shevchenko
<[email protected]> wrote:
> On Fri, Mar 19, 2021 at 9:05 AM kernel test robot <[email protected]> wrote:
> >
> > Hi Linus,
> >
> > FYI, the error/warning still remains.
(...)
> > In file included from include/linux/build_bug.h:5,
> > from include/linux/bitfield.h:10,
> > from drivers/iio/magnetometer/yamaha-yas530.c:22:
>
> Isn't it fixed already somewhere?
It is, I think Jonathan already applied the fix, it is just waiting to
percolate up
to Greg and then to Torvals:
https://lore.kernel.org/linux-iio/20210221154511.75b3d8a6@archlinux/
>> Kconfig warnings: (for reference only)
>> WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
>> Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
>> Selected by
>> - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
>> - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC
>
> This one though is interesting.
This looks like nothing to me :/
As confused as ever about Kconfig.
Yours,
Linus Walleij
On Mon, 22 Mar 2021 14:33:46 +0100
Linus Walleij <[email protected]> wrote:
> On Fri, Mar 19, 2021 at 10:57 AM Andy Shevchenko
> <[email protected]> wrote:
> > On Fri, Mar 19, 2021 at 9:05 AM kernel test robot <[email protected]> wrote:
> > >
> > > Hi Linus,
> > >
> > > FYI, the error/warning still remains.
> (...)
> > > In file included from include/linux/build_bug.h:5,
> > > from include/linux/bitfield.h:10,
> > > from drivers/iio/magnetometer/yamaha-yas530.c:22:
> >
> > Isn't it fixed already somewhere?
>
> It is, I think Jonathan already applied the fix, it is just waiting to
> percolate up
> to Greg and then to Torvals:
> https://lore.kernel.org/linux-iio/20210221154511.75b3d8a6@archlinux/
I'm being slow. Can apply it now as previous set of fixes have gone in.
I'll pick it up when I'm the right machine.
Jonathan
>
> >> Kconfig warnings: (for reference only)
> >> WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
> >> Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
> >> Selected by
> >> - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
> >> - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC
> >
> > This one though is interesting.
>
> This looks like nothing to me :/
> As confused as ever about Kconfig.
>
> Yours,
> Linus Walleij