2021-03-26 19:15:34

by Colin King

Subject: [PATCH] usb: cdnsp: remove redundant initialization of variable ret

From: Colin Ian King <[email protected]>

The variable ret is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/usb/cdns3/cdnsp-mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/cdns3/cdnsp-mem.c b/drivers/usb/cdns3/cdnsp-mem.c
index 7a84e928710e..d87b640e7b49 100644
--- a/drivers/usb/cdns3/cdnsp-mem.c
+++ b/drivers/usb/cdns3/cdnsp-mem.c
@@ -686,7 +686,7 @@ static void cdnsp_free_priv_device(struct cdnsp_device *pdev)

static int cdnsp_alloc_priv_device(struct cdnsp_device *pdev)
{
- int ret = -ENOMEM;
+ int ret;

ret = cdnsp_init_device_ctx(pdev);
if (ret)
--
2.30.2

2021-03-30 03:40:57

by Pawel Laszczak

Subject: RE: [PATCH] usb: cdnsp: remove redundant initialization of variable ret

Hi Colin,

Thanks for this fix.

>
>From: Colin Ian King <[email protected]>
>
>The variable ret is being initialized with a value that is
>never read and it is being updated later with a new value. The
>initialization is redundant and can be removed.
>
>Addresses-Coverity: ("Unused value")
>Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Pawel Laszczak <[email protected]>

>---
> drivers/usb/cdns3/cdnsp-mem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/usb/cdns3/cdnsp-mem.c b/drivers/usb/cdns3/cdnsp-mem.c
>index 7a84e928710e..d87b640e7b49 100644
>--- a/drivers/usb/cdns3/cdnsp-mem.c
>+++ b/drivers/usb/cdns3/cdnsp-mem.c
>@@ -686,7 +686,7 @@ static void cdnsp_free_priv_device(struct cdnsp_device *pdev)
>
> static int cdnsp_alloc_priv_device(struct cdnsp_device *pdev)
> {
>- int ret = -ENOMEM;
>+ int ret;
>
> ret = cdnsp_init_device_ctx(pdev);
> if (ret)
>--
>2.30.2

Regards,
Pawel Laszczak