For directories with negative dentries that are becoming case-insensitive
dirs, we need to remove all those negative dentries, otherwise they will
become dangling dentries. During the creation of a new file, if a d_hash
collision happens and the names match in a case-insensitive way, the name
of the file will be the name defined at the negative dentry, that may be
different from the specified by the user. To prevent this from
happening, we need to remove all dentries in a directory. Given that the
directory must be empty before we call this function we are sure that
all dentries there will be negative.
Create a function to remove all negative dentries from a directory, to
be used as explained above by filesystems that support case-insensitive
lookups.
Signed-off-by: André Almeida <[email protected]>
---
fs/dcache.c | 27 +++++++++++++++++++++++++++
include/linux/dcache.h | 1 +
2 files changed, 28 insertions(+)
diff --git a/fs/dcache.c b/fs/dcache.c
index 7d24ff7eb206..fafb3016d6fd 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -1723,6 +1723,33 @@ void d_invalidate(struct dentry *dentry)
}
EXPORT_SYMBOL(d_invalidate);
+/**
+ * d_clear_dir_neg_dentries - Remove negative dentries in an inode
+ * @dir: Directory to clear negative dentries
+ *
+ * For directories with negative dentries that are becoming case-insensitive
+ * dirs, we need to remove all those negative dentries, otherwise they will
+ * become dangling dentries. During the creation of a new file, if a d_hash
+ * collision happens and the names match in a case-insensitive, the name of
+ * the file will be the name defined at the negative dentry, that can be
+ * different from the specified by the user. To prevent this from happening, we
+ * need to remove all dentries in a directory. Given that the directory must be
+ * empty before we call this function we are sure that all dentries there will
+ * be negative.
+ */
+void d_clear_dir_neg_dentries(struct inode *dir)
+{
+ struct dentry *alias, *dentry;
+
+ hlist_for_each_entry(alias, &dir->i_dentry, d_u.d_alias) {
+ list_for_each_entry(dentry, &alias->d_subdirs, d_child) {
+ d_drop(dentry);
+ dput(dentry);
+ }
+ }
+}
+EXPORT_SYMBOL(d_clear_dir_neg_dentries);
+
/**
* __d_alloc - allocate a dcache entry
* @sb: filesystem it will belong to
diff --git a/include/linux/dcache.h b/include/linux/dcache.h
index c1e48014106f..c43cd0be077f 100644
--- a/include/linux/dcache.h
+++ b/include/linux/dcache.h
@@ -250,6 +250,7 @@ extern void shrink_dcache_sb(struct super_block *);
extern void shrink_dcache_parent(struct dentry *);
extern void shrink_dcache_for_umount(struct super_block *);
extern void d_invalidate(struct dentry *);
+extern void d_clear_dir_neg_dentries(struct inode *);
/* only used at mount-time */
extern struct dentry * d_make_root(struct inode *);
--
2.31.0
On Sun, Mar 28, 2021 at 11:43:54AM -0300, Andr? Almeida wrote:
> +/**
> + * d_clear_dir_neg_dentries - Remove negative dentries in an inode
> + * @dir: Directory to clear negative dentries
> + *
> + * For directories with negative dentries that are becoming case-insensitive
> + * dirs, we need to remove all those negative dentries, otherwise they will
> + * become dangling dentries. During the creation of a new file, if a d_hash
> + * collision happens and the names match in a case-insensitive, the name of
> + * the file will be the name defined at the negative dentry, that can be
> + * different from the specified by the user. To prevent this from happening, we
> + * need to remove all dentries in a directory. Given that the directory must be
> + * empty before we call this function we are sure that all dentries there will
> + * be negative.
> + */
This is quite the landmine of a function. It _assumes_ that the directory
is empty, and clears all dentries in it.
> +void d_clear_dir_neg_dentries(struct inode *dir)
> +{
> + struct dentry *alias, *dentry;
> +
> + hlist_for_each_entry(alias, &dir->i_dentry, d_u.d_alias) {
> + list_for_each_entry(dentry, &alias->d_subdirs, d_child) {
> + d_drop(dentry);
> + dput(dentry);
> + }
I would be happier if it included a check for negativity. d_is_negative()
or maybe this newfangled d_really_is_negative() (i haven't stayed up
to speed on the precise difference between the two)
> + }
> +}
> +EXPORT_SYMBOL(d_clear_dir_neg_dentries);
I'd rather see this _GPL for such an internal thing.