2021-03-29 11:01:14

by Heikki Krogerus

[permalink] [raw]
Subject: [PATCH 04/12] ARM: pxa: stargate2: Constify the software node

Additional device properties are always just a part of a
software fwnode. If the device properties are constant, the
software node can also be constant.

Signed-off-by: Heikki Krogerus <[email protected]>
Cc: Jonathan Cameron <[email protected]>
Cc: Daniel Mack <[email protected]>
Cc: Haojian Zhuang <[email protected]>
Cc: Robert Jarzmik <[email protected]>
---
arch/arm/mach-pxa/stargate2.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-pxa/stargate2.c b/arch/arm/mach-pxa/stargate2.c
index e2353f7dcf01a..7ad6274657686 100644
--- a/arch/arm/mach-pxa/stargate2.c
+++ b/arch/arm/mach-pxa/stargate2.c
@@ -794,6 +794,10 @@ static const struct property_entry pca9500_eeprom_properties[] = {
{ }
};

+static const struct software_node pca9500_eeprom_node = {
+ .properties = pca9500_eeprom_properties,
+};
+
/**
* stargate2_reset_bluetooth() reset the bluecore to ensure consistent state
**/
@@ -929,7 +933,7 @@ static struct i2c_board_info __initdata stargate2_i2c_board_info[] = {
}, {
.type = "24c02",
.addr = 0x57,
- .properties = pca9500_eeprom_properties,
+ .swnode = &pca9500_eeprom_node,
}, {
.type = "max1238",
.addr = 0x35,
--
2.30.2


2021-04-07 08:23:27

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH 04/12] ARM: pxa: stargate2: Constify the software node

On Mon, Mar 29, 2021 at 01:50:39PM +0300, Heikki Krogerus wrote:
> Additional device properties are always just a part of a
> software fwnode. If the device properties are constant, the
> software node can also be constant.
>
> Signed-off-by: Heikki Krogerus <[email protected]>
> Cc: Jonathan Cameron <[email protected]>
> Cc: Daniel Mack <[email protected]>
> Cc: Haojian Zhuang <[email protected]>
> Cc: Robert Jarzmik <[email protected]>

I like to apply it soon. Can we get an ack, please?

Attachments:
(No filename) (534.00 B)
 signature.asc (849.00 B)
 Download all attachments

2021-04-10 08:18:53

by Robert Jarzmik

[permalink] [raw]
Subject: Re: [PATCH 04/12] ARM: pxa: stargate2: Constify the software node

Wolfram Sang <[email protected]> writes:

> On Mon, Mar 29, 2021 at 01:50:39PM +0300, Heikki Krogerus wrote:
>> Additional device properties are always just a part of a
>> software fwnode. If the device properties are constant, the
>> software node can also be constant.
>>
>> Signed-off-by: Heikki Krogerus <[email protected]>
>> Cc: Jonathan Cameron <[email protected]>
>> Cc: Daniel Mack <[email protected]>
>> Cc: Haojian Zhuang <[email protected]>
>> Cc: Robert Jarzmik <[email protected]>
>
> I like to apply it soon. Can we get an ack, please?
Acked-by: Robert Jarzmik <[email protected]>

Cheers.

--
Robert