2021-03-14 16:51:51

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH v2 0/6] mips: bmips: fix and improve reboot nodes

These patches improve bmips bcm63xx device tree nodes.

v2: add missing BCM63268 patch.

Álvaro Fernández Rojas (6):
mips: bmips: fix syscon-reboot nodes
mips: bmips: bcm6328: populate device tree nodes
mips: bmips: bcm6358: populate device tree nodes
mips: bmips: bcm6362: populate device tree nodes
mips: bmips: bcm6368: populate device tree nodes
mips: bmips: bcm63268: populate device tree nodes

arch/mips/boot/dts/brcm/bcm3368.dtsi | 2 +-
arch/mips/boot/dts/brcm/bcm63268.dtsi | 132 +++++++++++++++++++++++---
arch/mips/boot/dts/brcm/bcm6328.dtsi | 119 ++++++++++++++++++++---
arch/mips/boot/dts/brcm/bcm6358.dtsi | 85 ++++++++++++++---
arch/mips/boot/dts/brcm/bcm6362.dtsi | 129 ++++++++++++++++++++++---
arch/mips/boot/dts/brcm/bcm6368.dtsi | 129 ++++++++++++++++++++++---
6 files changed, 530 insertions(+), 66 deletions(-)

--
2.20.1


2021-03-14 16:51:53

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH v2 6/6] mips: bmips: bcm63268: populate device tree nodes

- Rename periph_clk to periph_osc.
- Rename clkctl to periph_clk.
- Move syscon-reboot to subnode.
- Add hsspi-osc clock.
- Add watchdog.
- Add HS SPI controller
- Add NAND controller.
- Add USBH PHY.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
v2: add missing patch

arch/mips/boot/dts/brcm/bcm63268.dtsi | 130 +++++++++++++++++++++++---
1 file changed, 116 insertions(+), 14 deletions(-)

diff --git a/arch/mips/boot/dts/brcm/bcm63268.dtsi b/arch/mips/boot/dts/brcm/bcm63268.dtsi
index 052d2032d4e4..c3ce49ec675f 100644
--- a/arch/mips/boot/dts/brcm/bcm63268.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm63268.dtsi
@@ -29,16 +29,29 @@
};

clocks {
- periph_clk: periph-clk {
+ periph_osc: periph-osc {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <50000000>;
+ clock-output-names = "periph";
+ };
+
+ hsspi_osc: hsspi-osc {
+ compatible = "fixed-clock";
+
+ #clock-cells = <0>;
+
+ clock-frequency = <400000000>;
+ clock-output-names = "hsspi_osc";
};
};

aliases {
+ nflash = &nflash;
serial0 = &uart0;
serial1 = &uart1;
+ spi0 = &lsspi;
+ spi1 = &hsspi;
};

cpu_intc: interrupt-controller {
@@ -56,23 +69,22 @@
compatible = "simple-bus";
ranges;

- clkctl: clock-controller@10000004 {
+ periph_clk: clock-controller@10000004 {
compatible = "brcm,bcm63268-clocks";
reg = <0x10000004 0x4>;
#clock-cells = <1>;
};

- periph_cntl: syscon@10000008 {
+ pll_cntl: syscon@10000008 {
compatible = "syscon";
reg = <0x10000008 0x4>;
native-endian;
- };

- reboot: syscon-reboot@10000008 {
- compatible = "syscon-reboot";
- regmap = <&periph_cntl>;
- offset = <0x0>;
- mask = <0x1>;
+ reboot {
+ compatible = "syscon-reboot";
+ offset = <0x0>;
+ mask = <0x1>;
+ };
};

periph_rst: reset-controller@10000010 {
@@ -93,6 +105,16 @@
interrupts = <2>, <3>;
};

+ wdt: watchdog@1000009c {
+ compatible = "brcm,bcm7038-wdt";
+ reg = <0x1000009c 0xc>;
+
+ clocks = <&periph_osc>;
+ clock-names = "refclk";
+
+ timeout-sec = <30>;
+ };
+
uart0: serial@10000180 {
compatible = "brcm,bcm6345-uart";
reg = <0x10000180 0x18>;
@@ -100,12 +122,34 @@
interrupt-parent = <&periph_intc>;
interrupts = <5>;

- clocks = <&periph_clk>;
+ clocks = <&periph_osc>;
clock-names = "refclk";

status = "disabled";
};

+ nflash: nand@10000200 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,nand-bcm6368",
+ "brcm,brcmnand-v4.0",
+ "brcm,brcmnand";
+ reg = <0x10000200 0x180>,
+ <0x10000600 0x200>,
+ <0x100000b0 0x10>;
+ reg-names = "nand",
+ "nand-cache",
+ "nand-int-base";
+
+ interrupt-parent = <&periph_intc>;
+ interrupts = <50>;
+
+ clocks = <&periph_clk BCM63268_CLK_NAND>;
+ clock-names = "nand";
+
+ status = "disabled";
+ };
+
uart1: serial@100001a0 {
compatible = "brcm,bcm6345-uart";
reg = <0x100001a0 0x18>;
@@ -113,17 +157,44 @@
interrupt-parent = <&periph_intc>;
interrupts = <34>;

- clocks = <&periph_clk>;
+ clocks = <&periph_osc>;
clock-names = "refclk";

status = "disabled";
};

- leds0: led-controller@10001900 {
+ lsspi: spi@10000800 {
#address-cells = <1>;
#size-cells = <0>;
- compatible = "brcm,bcm6328-leds";
- reg = <0x10001900 0x24>;
+ compatible = "brcm,bcm6358-spi";
+ reg = <0x10000800 0x70c>;
+
+ interrupt-parent = <&periph_intc>;
+ interrupts = <80>;
+
+ clocks = <&periph_clk BCM63268_CLK_SPI>;
+ clock-names = "spi";
+
+ resets = <&periph_rst BCM63268_RST_SPI>;
+
+ status = "disabled";
+ };
+
+ hsspi: spi@10001000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,bcm6328-hsspi";
+ reg = <0x10001000 0x600>;
+
+ interrupt-parent = <&periph_intc>;
+ interrupts = <6>;
+
+ clocks = <&periph_clk BCM63268_CLK_HSSPI>,
+ <&hsspi_osc>;
+ clock-names = "hsspi",
+ "pll";
+
+ resets = <&periph_rst BCM63268_RST_SPI>;

status = "disabled";
};
@@ -134,6 +205,15 @@
#power-domain-cells = <1>;
};

+ leds0: led-controller@10001900 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,bcm6328-leds";
+ reg = <0x10001900 0x24>;
+
+ status = "disabled";
+ };
+
ehci: usb@10002500 {
compatible = "brcm,bcm63268-ehci", "generic-ehci";
reg = <0x10002500 0x100>;
@@ -142,6 +222,9 @@
interrupt-parent = <&periph_intc>;
interrupts = <10>;

+ phys = <&usbh 0>;
+ phy-names = "usb";
+
status = "disabled";
};

@@ -154,6 +237,25 @@
interrupt-parent = <&periph_intc>;
interrupts = <9>;

+ phys = <&usbh 0>;
+ phy-names = "usb";
+
+ status = "disabled";
+ };
+
+ usbh: usb-phy@10002700 {
+ compatible = "brcm,bcm63268-usbh-phy";
+ reg = <0x10002700 0x38>;
+ #phy-cells = <1>;
+
+ clocks = <&periph_clk BCM63268_CLK_USBH>;
+ clock-names = "usbh";
+
+ power-domains = <&periph_pwr BCM63268_POWER_DOMAIN_USBH>;
+
+ resets = <&periph_rst BCM63268_RST_USBH>;
+ reset-names = "usbh";
+
status = "disabled";
};
};
--
2.20.1

2021-03-14 16:53:22

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH v2 3/6] mips: bmips: bcm6358: populate device tree nodes

- Rename periph_clk to periph_osc.
- Rename clkctl to periph_clk.
- Move syscon-reboot to subnode.
- Add watchdog.
- Add SPI controller.
- Add USBH PHY.
- Add cfi-flash.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
v2: no changes

arch/mips/boot/dts/brcm/bcm6358.dtsi | 83 ++++++++++++++++++++++++----
1 file changed, 72 insertions(+), 11 deletions(-)

diff --git a/arch/mips/boot/dts/brcm/bcm6358.dtsi b/arch/mips/boot/dts/brcm/bcm6358.dtsi
index f5549a056bff..777c4379ed03 100644
--- a/arch/mips/boot/dts/brcm/bcm6358.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm6358.dtsi
@@ -28,16 +28,19 @@
};

clocks {
- periph_clk: periph-clk {
+ periph_osc: periph-osc {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <50000000>;
+ clock-output-names = "periph";
};
};

aliases {
+ pflash = &pflash;
serial0 = &uart0;
serial1 = &uart1;
+ spi0 = &lsspi;
};

cpu_intc: interrupt-controller {
@@ -55,23 +58,22 @@
compatible = "simple-bus";
ranges;

- clkctl: clock-controller@fffe0004 {
+ periph_clk: clock-controller@fffe0004 {
compatible = "brcm,bcm6358-clocks";
reg = <0xfffe0004 0x4>;
#clock-cells = <1>;
};

- periph_cntl: syscon@fffe0008 {
+ pll_cntl: syscon@fffe0008 {
compatible = "syscon";
reg = <0xfffe0008 0x4>;
native-endian;
- };

- reboot: syscon-reboot@fffe0008 {
- compatible = "syscon-reboot";
- regmap = <&periph_cntl>;
- offset = <0x0>;
- mask = <0x1>;
+ reboot {
+ compatible = "syscon-reboot";
+ offset = <0x0>;
+ mask = <0x1>;
+ };
};

periph_intc: interrupt-controller@fffe000c {
@@ -92,6 +94,16 @@
#reset-cells = <1>;
};

+ wdt: watchdog@fffe005c {
+ compatible = "brcm,bcm7038-wdt";
+ reg = <0xfffe005c 0xc>;
+
+ clocks = <&periph_osc>;
+ clock-names = "refclk";
+
+ timeout-sec = <30>;
+ };
+
leds0: led-controller@fffe00d0 {
#address-cells = <1>;
#size-cells = <0>;
@@ -108,7 +120,7 @@
interrupt-parent = <&periph_intc>;
interrupts = <2>;

- clocks = <&periph_clk>;
+ clocks = <&periph_osc>;
clock-names = "refclk";

status = "disabled";
@@ -121,18 +133,41 @@
interrupt-parent = <&periph_intc>;
interrupts = <3>;

- clocks = <&periph_clk>;
+ clocks = <&periph_osc>;
clock-names = "refclk";

status = "disabled";
};

+ lsspi: spi@fffe0800 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,bcm6358-spi";
+ reg = <0xfffe0800 0x70c>;
+
+ interrupt-parent = <&periph_intc>;
+ interrupts = <1>;
+
+ clocks = <&periph_clk BCM6358_CLK_SPI>;
+ clock-names = "spi";
+
+ resets = <&periph_rst BCM6358_RST_SPI>;
+ reset-names = "spi";
+
+ status = "disabled";
+ };
+
ehci: usb@fffe1300 {
compatible = "brcm,bcm6358-ehci", "generic-ehci";
reg = <0xfffe1300 0x100>;
big-endian;
+
interrupt-parent = <&periph_intc>;
interrupts = <10>;
+
+ phys = <&usbh 0>;
+ phy-names = "usb";
+
status = "disabled";
};

@@ -141,9 +176,35 @@
reg = <0xfffe1400 0x100>;
big-endian;
no-big-frame-no;
+
interrupt-parent = <&periph_intc>;
interrupts = <5>;
+
+ phys = <&usbh 0>;
+ phy-names = "usb";
+
+ status = "disabled";
+ };
+
+ usbh: usb-phy@fffe1500 {
+ compatible = "brcm,bcm6358-usbh-phy";
+ reg = <0xfffe1500 0x38>;
+ #phy-cells = <1>;
+
+ resets = <&periph_rst BCM6358_RST_USBH>;
+ reset-names = "usbh";
+
status = "disabled";
};
};
+
+ pflash: nor@1e000000 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "cfi-flash";
+ reg = <0x1e000000 0x2000000>;
+ bank-width = <2>;
+
+ status = "disabled";
+ };
};
--
2.20.1

2021-03-14 16:53:36

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH v2 5/6] mips: bmips: bcm6368: populate device tree nodes

- Rename periph_clk to periph_osc.
- Rename clkctl to periph_clk.
- Move syscon-reboot to subnode.
- Add watchdog controller.
- Add SPI controller.
- Add NAND controller.
- Add USBH PHY controller.
- Add RNG controller.
- Add cfi-flash controller.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
v2: no changes

arch/mips/boot/dts/brcm/bcm6368.dtsi | 127 ++++++++++++++++++++++++---
1 file changed, 116 insertions(+), 11 deletions(-)

diff --git a/arch/mips/boot/dts/brcm/bcm6368.dtsi b/arch/mips/boot/dts/brcm/bcm6368.dtsi
index 4837b1436714..fc15e200877d 100644
--- a/arch/mips/boot/dts/brcm/bcm6368.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm6368.dtsi
@@ -28,16 +28,20 @@
};

clocks {
- periph_clk: periph-clk {
+ periph_osc: periph-osc {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <50000000>;
+ clock-output-names = "periph";
};
};

aliases {
+ nflash = &nflash;
+ pflash = &pflash;
serial0 = &uart0;
serial1 = &uart1;
+ spi0 = &lsspi;
};

cpu_intc: interrupt-controller {
@@ -55,23 +59,22 @@
compatible = "simple-bus";
ranges;

- clkctl: clock-controller@10000004 {
+ periph_clk: clock-controller@10000004 {
compatible = "brcm,bcm6368-clocks";
reg = <0x10000004 0x4>;
#clock-cells = <1>;
};

- periph_cntl: syscon@100000008 {
+ pll_cntl: syscon@100000008 {
compatible = "syscon";
reg = <0x10000008 0x4>;
native-endian;
- };

- reboot: syscon-reboot@10000008 {
- compatible = "syscon-reboot";
- regmap = <&periph_cntl>;
- offset = <0x0>;
- mask = <0x1>;
+ reboot {
+ compatible = "syscon-reboot";
+ offset = <0x0>;
+ mask = <0x1>;
+ };
};

periph_rst: reset-controller@10000010 {
@@ -92,31 +95,88 @@
interrupts = <2>, <3>;
};

+ wdt: watchdog@1000005c {
+ compatible = "brcm,bcm7038-wdt";
+ reg = <0x1000005c 0xc>;
+
+ clocks = <&periph_osc>;
+ clock-names = "refclk";
+
+ timeout-sec = <30>;
+ };
+
leds0: led-controller@100000d0 {
#address-cells = <1>;
#size-cells = <0>;
compatible = "brcm,bcm6358-leds";
reg = <0x100000d0 0x8>;
+
status = "disabled";
};

uart0: serial@10000100 {
compatible = "brcm,bcm6345-uart";
reg = <0x10000100 0x18>;
+
interrupt-parent = <&periph_intc>;
interrupts = <2>;
- clocks = <&periph_clk>;
+
+ clocks = <&periph_osc>;
clock-names = "refclk";
+
status = "disabled";
};

uart1: serial@10000120 {
compatible = "brcm,bcm6345-uart";
reg = <0x10000120 0x18>;
+
interrupt-parent = <&periph_intc>;
interrupts = <3>;
- clocks = <&periph_clk>;
+
+ clocks = <&periph_osc>;
clock-names = "refclk";
+
+ status = "disabled";
+ };
+
+ nflash: nand@10000200 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,nand-bcm6368",
+ "brcm,brcmnand-v2.1",
+ "brcm,brcmnand";
+ reg = <0x10000200 0x180>,
+ <0x10000600 0x200>,
+ <0x10000070 0x10>;
+ reg-names = "nand",
+ "nand-cache",
+ "nand-int-base";
+
+ interrupt-parent = <&periph_intc>;
+ interrupts = <10>;
+
+ clocks = <&periph_clk BCM6368_CLK_NAND>;
+ clock-names = "nand";
+
+ status = "disabled";
+ };
+
+ lsspi: spi@10000800 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,bcm6358-spi";
+ reg = <0x10000800 0x70c>;
+
+ interrupt-parent = <&periph_intc>;
+ interrupts = <1>;
+
+ clocks = <&periph_clk BCM6368_CLK_SPI>;
+ clock-names = "spi";
+
+ resets = <&periph_rst BCM6368_RST_SPI>;
+ reset-names = "spi";
+
status = "disabled";
};

@@ -124,8 +184,13 @@
compatible = "brcm,bcm6368-ehci", "generic-ehci";
reg = <0x10001500 0x100>;
big-endian;
+
interrupt-parent = <&periph_intc>;
interrupts = <7>;
+
+ phys = <&usbh 0>;
+ phy-names = "usb";
+
status = "disabled";
};

@@ -134,9 +199,49 @@
reg = <0x10001600 0x100>;
big-endian;
no-big-frame-no;
+
interrupt-parent = <&periph_intc>;
interrupts = <5>;
+
+ phys = <&usbh 0>;
+ phy-names = "usb";
+
+ status = "disabled";
+ };
+
+ usbh: usb-phy@10001700 {
+ compatible = "brcm,bcm6368-usbh-phy";
+ reg = <0x10001700 0x38>;
+ #phy-cells = <1>;
+
+ clocks = <&periph_clk BCM6368_CLK_USBH>;
+ clock-names = "usbh";
+
+ resets = <&periph_rst BCM6368_RST_USBH>;
+ reset-names = "usbh";
+
status = "disabled";
};
+
+ random: rng@10004180 {
+ compatible = "brcm,bcm6368-rng";
+ reg = <0x10004180 0x14>;
+
+ clocks = <&periph_clk BCM6368_CLK_IPSEC>;
+ clock-names = "ipsec";
+
+ resets = <&periph_rst BCM6368_RST_IPSEC>;
+ reset-names = "ipsec";
+ };
+ };
+
+ pflash: nor@18000000 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "cfi-flash";
+ reg = <0x18000000 0x2000000>;
+ bank-width = <2>;
+
+ status = "disabled";
};
};
--
2.20.1

2021-03-30 13:12:59

by Thomas Bogendoerfer

[permalink] [raw]
Subject: Re: [PATCH v2 0/6] mips: bmips: fix and improve reboot nodes

On Sun, Mar 14, 2021 at 05:43:45PM +0100, ?lvaro Fern?ndez Rojas wrote:
> These patches improve bmips bcm63xx device tree nodes.
>
> v2: add missing BCM63268 patch.
>
> ?lvaro Fern?ndez Rojas (6):
> mips: bmips: fix syscon-reboot nodes
> mips: bmips: bcm6328: populate device tree nodes
> mips: bmips: bcm6358: populate device tree nodes
> mips: bmips: bcm6362: populate device tree nodes
> mips: bmips: bcm6368: populate device tree nodes
> mips: bmips: bcm63268: populate device tree nodes
>
> arch/mips/boot/dts/brcm/bcm3368.dtsi | 2 +-
> arch/mips/boot/dts/brcm/bcm63268.dtsi | 132 +++++++++++++++++++++++---
> arch/mips/boot/dts/brcm/bcm6328.dtsi | 119 ++++++++++++++++++++---
> arch/mips/boot/dts/brcm/bcm6358.dtsi | 85 ++++++++++++++---
> arch/mips/boot/dts/brcm/bcm6362.dtsi | 129 ++++++++++++++++++++++---
> arch/mips/boot/dts/brcm/bcm6368.dtsi | 129 ++++++++++++++++++++++---
> 6 files changed, 530 insertions(+), 66 deletions(-)

Florian, are you ok with this changes ? If yes, I'm going to apply them
to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]

2021-03-30 17:11:21

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH v2 3/6] mips: bmips: bcm6358: populate device tree nodes

On 3/14/21 9:43 AM, Álvaro Fernández Rojas wrote:
> - Rename periph_clk to periph_osc.
> - Rename clkctl to periph_clk.
> - Move syscon-reboot to subnode.
> - Add watchdog.
> - Add SPI controller.
> - Add USBH PHY.
> - Add cfi-flash.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Reviewed-by: Florian Fainelli <[email protected]>
--
Florian

2021-03-30 17:13:17

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH v2 5/6] mips: bmips: bcm6368: populate device tree nodes

On 3/14/21 9:43 AM, Álvaro Fernández Rojas wrote:
> - Rename periph_clk to periph_osc.
> - Rename clkctl to periph_clk.
> - Move syscon-reboot to subnode.
> - Add watchdog controller.
> - Add SPI controller.
> - Add NAND controller.
> - Add USBH PHY controller.
> - Add RNG controller.
> - Add cfi-flash controller.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Reviewed-by: Florian Fainelli <[email protected]>
--
Florian

2021-03-30 17:15:14

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH v2 6/6] mips: bmips: bcm63268: populate device tree nodes

On 3/14/21 9:43 AM, Álvaro Fernández Rojas wrote:
> - Rename periph_clk to periph_osc.
> - Rename clkctl to periph_clk.
> - Move syscon-reboot to subnode.
> - Add hsspi-osc clock.
> - Add watchdog.
> - Add HS SPI controller
> - Add NAND controller.
> - Add USBH PHY.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Reviewed-by: Florian Fainelli <[email protected]>
--
Florian

2021-03-30 17:15:47

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH v2 0/6] mips: bmips: fix and improve reboot nodes

On 3/30/21 6:09 AM, Thomas Bogendoerfer wrote:
> On Sun, Mar 14, 2021 at 05:43:45PM +0100, Álvaro Fernández Rojas wrote:
>> These patches improve bmips bcm63xx device tree nodes.
>>
>> v2: add missing BCM63268 patch.
>>
>> Álvaro Fernández Rojas (6):
>> mips: bmips: fix syscon-reboot nodes
>> mips: bmips: bcm6328: populate device tree nodes
>> mips: bmips: bcm6358: populate device tree nodes
>> mips: bmips: bcm6362: populate device tree nodes
>> mips: bmips: bcm6368: populate device tree nodes
>> mips: bmips: bcm63268: populate device tree nodes
>>
>> arch/mips/boot/dts/brcm/bcm3368.dtsi | 2 +-
>> arch/mips/boot/dts/brcm/bcm63268.dtsi | 132 +++++++++++++++++++++++---
>> arch/mips/boot/dts/brcm/bcm6328.dtsi | 119 ++++++++++++++++++++---
>> arch/mips/boot/dts/brcm/bcm6358.dtsi | 85 ++++++++++++++---
>> arch/mips/boot/dts/brcm/bcm6362.dtsi | 129 ++++++++++++++++++++++---
>> arch/mips/boot/dts/brcm/bcm6368.dtsi | 129 ++++++++++++++++++++++---
>> 6 files changed, 530 insertions(+), 66 deletions(-)
>
> Florian, are you ok with this changes ? If yes, I'm going to apply them
> to mips-next.

This all looks good to me and matches the hardware manuals as far as
resources are declared. There may be some room for doing a bit more
consolidation since there is not that much difference between SoCs after
all, maybe as a subsequent change.
--
Florian

2021-04-06 22:10:53

by Thomas Bogendoerfer

[permalink] [raw]
Subject: Re: [PATCH v2 0/6] mips: bmips: fix and improve reboot nodes

On Sun, Mar 14, 2021 at 05:43:45PM +0100, ?lvaro Fern?ndez Rojas wrote:
> These patches improve bmips bcm63xx device tree nodes.
>
> v2: add missing BCM63268 patch.
>
> ?lvaro Fern?ndez Rojas (6):
> mips: bmips: fix syscon-reboot nodes
> mips: bmips: bcm6328: populate device tree nodes
> mips: bmips: bcm6358: populate device tree nodes
> mips: bmips: bcm6362: populate device tree nodes
> mips: bmips: bcm6368: populate device tree nodes
> mips: bmips: bcm63268: populate device tree nodes
>
> arch/mips/boot/dts/brcm/bcm3368.dtsi | 2 +-
> arch/mips/boot/dts/brcm/bcm63268.dtsi | 132 +++++++++++++++++++++++---
> arch/mips/boot/dts/brcm/bcm6328.dtsi | 119 ++++++++++++++++++++---
> arch/mips/boot/dts/brcm/bcm6358.dtsi | 85 ++++++++++++++---
> arch/mips/boot/dts/brcm/bcm6362.dtsi | 129 ++++++++++++++++++++++---
> arch/mips/boot/dts/brcm/bcm6368.dtsi | 129 ++++++++++++++++++++++---
> 6 files changed, 530 insertions(+), 66 deletions(-)

series applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]