2021-03-31 09:34:37

by Qiheng Lin

Subject: [PATCH -next] memory: fsl-corenet-cf: Remove redundant dev_err call in ccf_probe()

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Qiheng Lin <[email protected]>
---
drivers/memory/fsl-corenet-cf.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/memory/fsl-corenet-cf.c b/drivers/memory/fsl-corenet-cf.c
index 0309bd5a1800..e15c962d4540 100644
--- a/drivers/memory/fsl-corenet-cf.c
+++ b/drivers/memory/fsl-corenet-cf.c
@@ -192,10 +192,8 @@ static int ccf_probe(struct platform_device *pdev)
}

ccf->regs = devm_ioremap_resource(&pdev->dev, r);
- if (IS_ERR(ccf->regs)) {
- dev_err(&pdev->dev, "%s: can't map mem resource\n", __func__);
+ if (IS_ERR(ccf->regs))
return PTR_ERR(ccf->regs);
- }

ccf->dev = &pdev->dev;
ccf->info = match->data;

2021-04-01 20:03:55

by Krzysztof Kozlowski

Subject: Re: [PATCH -next] memory: fsl-corenet-cf: Remove redundant dev_err call in ccf_probe()

On Wed, 31 Mar 2021 17:32:44 +0800, Qiheng Lin wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.

Applied, thanks!

[1/1] memory: fsl-corenet-cf: Remove redundant dev_err call in ccf_probe()
commit: b11a188aef6d19fe3ca505831d9c627ef683476f

Best regards,
--
Krzysztof Kozlowski <[email protected]>