2021-04-01 17:48:39

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH V2 2/3] dt-bindings: pinctrl: qcom-pmic-gpio: Update the binding to add four new variants

On Thu 01 Apr 07:35 CDT 2021, satya priya wrote:

> Update the binding to add PM7325, PM8350C, PMK8350 and PMR735A GPIO support.
>
> Signed-off-by: satya priya <[email protected]>
> ---
> Changes in V2:
> - Placed this patch before conversion patch and updated commit text
> to be more clear.
>
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> index 7648ab0..da7c35e 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> @@ -30,6 +30,10 @@ PMIC's from Qualcomm.
> "qcom,pm6150-gpio"
> "qcom,pm6150l-gpio"
> "qcom,pmx55-gpio"
> + "qcom,pm7325-gpio"
> + "qcom,pm8350c-gpio"
> + "qcom,pmk8350-gpio"
> + "qcom,pmr735a-gpio"

As with the driver, please try to keep these sorted alphabetically and
please rebase on linux-next, which already defines 2 of these.

Regards,
Bjorn

>
> And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
> if the device is on an spmi bus or an ssbi bus respectively
> @@ -113,6 +117,10 @@ to specify in a pin configuration subnode:
> gpio1-gpio12 for pm6150l
> gpio1-gpio11 for pmx55 (holes on gpio3, gpio7, gpio10
> and gpio11)
> + gpio1-gpio10 for pm7325
> + gpio1-gpio9 for pm8350c
> + gpio1-gpio4 for pmk8350
> + gpio1-gpio4 for pmr735a
>
> - function:
> Usage: required
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>