2021-04-06 20:50:45

by Clark Wang

Subject: [PATCH V2 15/18] dt-bindings: i2c: imx-lpi2c: Add dma configuration example

Add i2c bus dma mode configuration example.

Signed-off-by: Clark Wang <[email protected]>
---
V2 changes:
- New patch added in V2
---
.../devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
index 0a4b28827dcc..3868fec0cf27 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
@@ -51,6 +51,16 @@ properties:
sda-gpios:
maxItems: 1

+ dmas:
+ minItems: 2
+ maxItems: 2
+
+ dma-names:
+ minItems: 2
+ maxItems: 2
+ items:
+ enum: [ "tx", "rx" ]
+
required:
- compatible
- reg
@@ -75,4 +85,6 @@ examples:
pinctrl-1 = <&pinctrl_i2c_recovery>;
scl-gpios = <&gpio5 14 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
sda-gpios = <&gpio5 15 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
+ dmas = <&edma1 0 16>, <&edma1 0 15>;
+ dma-names = "tx","rx";
};
--
2.25.1

2021-04-09 16:34:47

by Rob Herring (Arm)

Subject: Re: [PATCH V2 15/18] dt-bindings: i2c: imx-lpi2c: Add dma configuration example

On Tue, Apr 06, 2021 at 07:33:03PM +0800, Clark Wang wrote:
> Add i2c bus dma mode configuration example.
>
> Signed-off-by: Clark Wang <[email protected]>
> ---
> V2 changes:
> - New patch added in V2
> ---
> .../devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
> index 0a4b28827dcc..3868fec0cf27 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
> @@ -51,6 +51,16 @@ properties:
> sda-gpios:
> maxItems: 1
>
> + dmas:
> + minItems: 2
> + maxItems: 2
> +
> + dma-names:
> + minItems: 2
> + maxItems: 2
> + items:
> + enum: [ "tx", "rx" ]

Please define the order:

items:
- const: tx
- const: rx

> +
> required:
> - compatible
> - reg
> @@ -75,4 +85,6 @@ examples:
> pinctrl-1 = <&pinctrl_i2c_recovery>;
> scl-gpios = <&gpio5 14 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> sda-gpios = <&gpio5 15 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + dmas = <&edma1 0 16>, <&edma1 0 15>;
> + dma-names = "tx","rx";
> };
> --
> 2.25.1
>