2021-04-21 04:35:03

by Samuel Holland

[permalink] [raw]
Subject: [PATCH 0/2] Allwinner H6 USB3 device tree updates

While implementing support for this USB controller in U-Boot, I noticed
that the reset line alsp affects they PHY. It looks like most platforms
use a separate glue node to represent this, and in fact there is already
a compatible for the H6 listed in drivers/usb/dwc3/dwc3-of-simple.c.

Since this layout matches the usual way of modeling this hardware, it
allows using the existing drivers without adding platform-specific code.

Samuel Holland (2):
dt-bindings: usb: Document the Allwinner H6 DWC3 glue
arm64: dts: allwinner: h6: Wrap DWC3 and PHY in glue layer

.../usb/allwinner,sun50i-h6-dwc3.yaml | 75 +++++++++++++++++++
.../dts/allwinner/sun50i-h6-beelink-gs1.dts | 6 +-
.../dts/allwinner/sun50i-h6-orangepi-3.dts | 6 +-
.../boot/dts/allwinner/sun50i-h6-pine-h64.dts | 9 +--
.../dts/allwinner/sun50i-h6-tanix-tx6.dts | 6 +-
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 60 ++++++++-------
6 files changed, 115 insertions(+), 47 deletions(-)
create mode 100644 Documentation/devicetree/bindings/usb/allwinner,sun50i-h6-dwc3.yaml

--
2.26.3


2021-04-21 09:30:16

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH 0/2] Allwinner H6 USB3 device tree updates

Hi,

On Tue, Apr 20, 2021 at 11:28:32PM -0500, Samuel Holland wrote:
> While implementing support for this USB controller in U-Boot, I noticed
> that the reset line alsp affects they PHY. It looks like most platforms
> use a separate glue node to represent this, and in fact there is already
> a compatible for the H6 listed in drivers/usb/dwc3/dwc3-of-simple.c.
>
> Since this layout matches the usual way of modeling this hardware, it
> allows using the existing drivers without adding platform-specific code.

I'm not sure which branch you based this on, but the Pine H64 seems to
be missing the USB3 support in the first place. I've applied the rest of
the changes though, thanks!

Maxime


Attachments:
(No filename) (710.00 B)
signature.asc (235.00 B)
Download all attachments