2021-01-08 09:27:22

by Zheng Yongjun

[permalink] [raw]
Subject: [PATCH v2 -next] leds: convert comma to semicolon

Replace a comma between expression statements by a semicolon.

Signed-off-by: Zheng Yongjun <[email protected]>
---
drivers/leds/leds-lm3642.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/leds/leds-lm3642.c b/drivers/leds/leds-lm3642.c
index 62c14872caf7..22035a380c4a 100644
--- a/drivers/leds/leds-lm3642.c
+++ b/drivers/leds/leds-lm3642.c
@@ -339,7 +339,7 @@ static int lm3642_probe(struct i2c_client *client,
chip->cdev_flash.max_brightness = 16;
chip->cdev_flash.brightness_set_blocking = lm3642_strobe_brightness_set;
chip->cdev_flash.default_trigger = "flash";
- chip->cdev_flash.groups = lm3642_flash_groups,
+ chip->cdev_flash.groups = lm3642_flash_groups;
err = led_classdev_register(&client->dev, &chip->cdev_flash);
if (err < 0) {
dev_err(chip->dev, "failed to register flash\n");
@@ -351,7 +351,7 @@ static int lm3642_probe(struct i2c_client *client,
chip->cdev_torch.max_brightness = 8;
chip->cdev_torch.brightness_set_blocking = lm3642_torch_brightness_set;
chip->cdev_torch.default_trigger = "torch";
- chip->cdev_torch.groups = lm3642_torch_groups,
+ chip->cdev_torch.groups = lm3642_torch_groups;
err = led_classdev_register(&client->dev, &chip->cdev_torch);
if (err < 0) {
dev_err(chip->dev, "failed to register torch\n");
--
2.22.0


2021-01-08 13:17:51

by Dan Murphy

[permalink] [raw]
Subject: Re: [PATCH v2 -next] leds: convert comma to semicolon

Hello

On 1/8/21 3:24 AM, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.

Can you add a "Fixes" tag here?

Dan

2021-01-08 15:47:48

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH v2 -next] leds: convert comma to semicolon

On Fri 2021-01-08 07:14:08, Dan Murphy wrote:
> Hello
>
> On 1/8/21 3:24 AM, Zheng Yongjun wrote:
> > Replace a comma between expression statements by a semicolon.
>
> Can you add a "Fixes" tag here?

Don't. Its just cleanup, we don't want it in stable. Patch is fine as is.

--

2021-04-25 20:40:55

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH v2 -next] leds: convert comma to semicolon


On Fri 2021-01-08 17:24:46, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.

Thanks, applied.
Pavel

--
http://www.livejournal.com/~pavelmachek


Attachments:
(No filename) (206.00 B)
signature.asc (188.00 B)
Digital signature
Download all attachments