2021-05-03 07:04:40

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] i2c: icy: Remove unused variable new_fwnode in icy_probe()

The last user of new_fwnode was removed, leading to:

drivers/i2c/busses/i2c-icy.c: In function ‘icy_probe’:
drivers/i2c/busses/i2c-icy.c:126:24: warning: unused variable ‘new_fwnode’ [-Wunused-variable]
126 | struct fwnode_handle *new_fwnode;
| ^~~~~~~~~~

Fixes: dd7a37102b79ae55 ("i2c: icy: Constify the software node")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/i2c/busses/i2c-icy.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-icy.c b/drivers/i2c/busses/i2c-icy.c
index c8c422e9dda43393..5dae7cab72605592 100644
--- a/drivers/i2c/busses/i2c-icy.c
+++ b/drivers/i2c/busses/i2c-icy.c
@@ -123,7 +123,6 @@ static int icy_probe(struct zorro_dev *z,
{
struct icy_i2c *i2c;
struct i2c_algo_pcf_data *algo_data;
- struct fwnode_handle *new_fwnode;
struct i2c_board_info ltc2990_info = {
.type = "ltc2990",
.swnode = &icy_ltc2990_node,
--
2.25.1


2021-05-03 18:06:54

by Max Staudt

[permalink] [raw]
Subject: Re: [PATCH] i2c: icy: Remove unused variable new_fwnode in icy_probe()

Thanks for catching this warning :)


Reviewed-by: Max Staudt <[email protected]>

2021-05-25 23:32:46

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] i2c: icy: Remove unused variable new_fwnode in icy_probe()

On Mon, May 03, 2021 at 09:02:20AM +0200, Geert Uytterhoeven wrote:
> The last user of new_fwnode was removed, leading to:
>
> drivers/i2c/busses/i2c-icy.c: In function ‘icy_probe’:
> drivers/i2c/busses/i2c-icy.c:126:24: warning: unused variable ‘new_fwnode’ [-Wunused-variable]
> 126 | struct fwnode_handle *new_fwnode;
> | ^~~~~~~~~~
>
> Fixes: dd7a37102b79ae55 ("i2c: icy: Constify the software node")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Applied to for-current, thanks!


Attachments:
(No filename) (562.00 B)
signature.asc (849.00 B)
Download all attachments