2021-05-03 18:42:11

by Corentin LABBE

Subject: [PATCH v4] dt-bindings: net: Convert mdio-gpio to yaml

Converts net/mdio-gpio.txt to yaml

Reviewed-by: Andrew Lunn <[email protected]>
Signed-off-by: Corentin Labbe <[email protected]>
---
Changes since v1:
- fixes yamllint warning about indent
- added maxItems 3

Changes since v2:
- fixed example (gpios need 2 entries)

Changes since v3:
- fixed gpios description
- added additionalProperties/type: object

.../devicetree/bindings/net/mdio-gpio.txt | 27 ---------
.../devicetree/bindings/net/mdio-gpio.yaml | 58 +++++++++++++++++++
2 files changed, 58 insertions(+), 27 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/net/mdio-gpio.txt
create mode 100644 Documentation/devicetree/bindings/net/mdio-gpio.yaml

diff --git a/Documentation/devicetree/bindings/net/mdio-gpio.txt b/Documentation/devicetree/bindings/net/mdio-gpio.txt
deleted file mode 100644
index 4d91a36c5cf5..000000000000
--- a/Documentation/devicetree/bindings/net/mdio-gpio.txt
+++ /dev/null
@@ -1,27 +0,0 @@
-MDIO on GPIOs
-
-Currently defined compatibles:
-- virtual,gpio-mdio
-- microchip,mdio-smi0
-
-MDC and MDIO lines connected to GPIO controllers are listed in the
-gpios property as described in section VIII.1 in the following order:
-
-MDC, MDIO.
-
-Note: Each gpio-mdio bus should have an alias correctly numbered in "aliases"
-node.
-
-Example:
-
-aliases {
- mdio-gpio0 = &mdio0;
-};
-
-mdio0: mdio {
- compatible = "virtual,mdio-gpio";
- #address-cells = <1>;
- #size-cells = <0>;
- gpios = <&qe_pio_a 11
- &qe_pio_c 6>;
-};
diff --git a/Documentation/devicetree/bindings/net/mdio-gpio.yaml b/Documentation/devicetree/bindings/net/mdio-gpio.yaml
new file mode 100644
index 000000000000..236a8c4768e2
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/mdio-gpio.yaml
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/mdio-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MDIO on GPIOs
+
+maintainers:
+ - Andrew Lunn <[email protected]>
+ - Florian Fainelli <[email protected]>
+ - Heiner Kallweit <[email protected]>
+
+allOf:
+ - $ref: "mdio.yaml#"
+
+properties:
+ compatible:
+ enum:
+ - virtual,mdio-gpio
+ - microchip,mdio-smi0
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+ gpios:
+ minItems: 2
+ maxItems: 3
+ items:
+ - description: MDC
+ - description: MDIO
+ - description: MDO
+
+#Note: Each gpio-mdio bus should have an alias correctly numbered in "aliases"
+#node.
+additionalProperties:
+ type: object
+
+examples:
+ - |
+ aliases {
+ mdio-gpio0 = &mdio0;
+ };
+
+ mdio0: mdio {
+ compatible = "virtual,mdio-gpio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ gpios = <&qe_pio_a 11>,
+ <&qe_pio_c 6>;
+ ethphy0: ethernet-phy@0 {
+ reg = <0>;
+ };
+ };
+...
--
2.26.3

2021-05-03 19:02:38

by Russell King (Oracle)

Subject: Re: [PATCH v4] dt-bindings: net: Convert mdio-gpio to yaml

On Mon, May 03, 2021 at 06:41:00PM +0000, Corentin Labbe wrote:
> Converts net/mdio-gpio.txt to yaml
>
> Reviewed-by: Andrew Lunn <[email protected]>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> Changes since v1:
> - fixes yamllint warning about indent
> - added maxItems 3
>
> Changes since v2:
> - fixed example (gpios need 2 entries)
>
> Changes since v3:
> - fixed gpios description
> - added additionalProperties/type: object
>
> .../devicetree/bindings/net/mdio-gpio.txt | 27 ---------
> .../devicetree/bindings/net/mdio-gpio.yaml | 58 +++++++++++++++++++
> 2 files changed, 58 insertions(+), 27 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/net/mdio-gpio.txt
> create mode 100644 Documentation/devicetree/bindings/net/mdio-gpio.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/mdio-gpio.txt b/Documentation/devicetree/bindings/net/mdio-gpio.txt
> deleted file mode 100644
> index 4d91a36c5cf5..000000000000
> --- a/Documentation/devicetree/bindings/net/mdio-gpio.txt
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -MDIO on GPIOs
> -
> -Currently defined compatibles:
> -- virtual,gpio-mdio
> -- microchip,mdio-smi0
> -
> -MDC and MDIO lines connected to GPIO controllers are listed in the
> -gpios property as described in section VIII.1 in the following order:
> -
> -MDC, MDIO.
> -
> -Note: Each gpio-mdio bus should have an alias correctly numbered in "aliases"
> -node.
> -
> -Example:
> -
> -aliases {
> - mdio-gpio0 = &mdio0;
> -};
> -
> -mdio0: mdio {
> - compatible = "virtual,mdio-gpio";
> - #address-cells = <1>;
> - #size-cells = <0>;
> - gpios = <&qe_pio_a 11
> - &qe_pio_c 6>;
> -};
> diff --git a/Documentation/devicetree/bindings/net/mdio-gpio.yaml b/Documentation/devicetree/bindings/net/mdio-gpio.yaml
> new file mode 100644
> index 000000000000..236a8c4768e2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/mdio-gpio.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/mdio-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MDIO on GPIOs
> +
> +maintainers:
> + - Andrew Lunn <[email protected]>
> + - Florian Fainelli <[email protected]>
> + - Heiner Kallweit <[email protected]>

I think your information is outdated here. As the original does not
contain this information, and maintainers no longer lists Florian,
I can only guess that this patch was created some time ago?

Please update this with the latest from MAINTAINERS, thanks.

> +
> +allOf:
> + - $ref: "mdio.yaml#"
> +
> +properties:
> + compatible:
> + enum:
> + - virtual,mdio-gpio
> + - microchip,mdio-smi0
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + gpios:
> + minItems: 2
> + maxItems: 3
> + items:
> + - description: MDC
> + - description: MDIO
> + - description: MDO
> +
> +#Note: Each gpio-mdio bus should have an alias correctly numbered in "aliases"
> +#node.
> +additionalProperties:
> + type: object
> +
> +examples:
> + - |
> + aliases {
> + mdio-gpio0 = &mdio0;
> + };
> +
> + mdio0: mdio {
> + compatible = "virtual,mdio-gpio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + gpios = <&qe_pio_a 11>,
> + <&qe_pio_c 6>;
> + ethphy0: ethernet-phy@0 {
> + reg = <0>;
> + };
> + };
> +...
> --
> 2.26.3
>
>

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!