Sparse says:
arch/x86/kernel/alternative.c:78:21: warning: symbol 'x86nops' was not declared. Should it be static?
Since x86nops is not used outside this file,
it can be made static.
Signed-off-by: Pavel Skripkin <[email protected]>
---
arch/x86/kernel/alternative.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index 6974b5174495..75c752b0628c 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -75,7 +75,7 @@ do { \
} \
} while (0)
-const unsigned char x86nops[] =
+static const unsigned char x86nops[] =
{
BYTES_NOP1,
BYTES_NOP2,
--
2.31.1
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: 64e1f5872a8c3d80bce4686b4ab5dbc6e6bd30c5
Gitweb: https://git.kernel.org/tip/64e1f5872a8c3d80bce4686b4ab5dbc6e6bd30c5
Author: Pavel Skripkin <[email protected]>
AuthorDate: Thu, 06 May 2021 22:07:26 +03:00
Committer: Ingo Molnar <[email protected]>
CommitterDate: Wed, 12 May 2021 12:22:56 +02:00
x86/alternatives: Make the x86nops[] symbol static
Sparse says:
arch/x86/kernel/alternative.c:78:21: warning: symbol 'x86nops' was not declared. Should it be static?
Since x86nops[] is not used outside this file, Sparse is right and it can be made static.
Signed-off-by: Pavel Skripkin <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
arch/x86/kernel/alternative.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index 6974b51..75c752b 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -75,7 +75,7 @@ do { \
} \
} while (0)
-const unsigned char x86nops[] =
+static const unsigned char x86nops[] =
{
BYTES_NOP1,
BYTES_NOP2,