2021-05-10 17:37:21

by Johan Jonker

Subject: [PATCH] ARM: dts: rockchip: Remove more clock-names from PWM nodes A test with the command below gives this error:

/arch/arm/boot/dts/rk3228-evb.dt.yaml:
pwm@110b0020: clock-names: ['pwm'] is too short

Devices with only one PWM clock use it to both to derive the functional
clock for the device and as the bus clock. The driver does not need
"clock-names" to get a handle, so remove them all.

make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml

Signed-off-by: Johan Jonker <[email protected]>
---
arch/arm/boot/dts/rk322x.dtsi | 4 ----
1 file changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
index 9fbd96c3f..61028a5c9 100644
--- a/arch/arm/boot/dts/rk322x.dtsi
+++ b/arch/arm/boot/dts/rk322x.dtsi
@@ -384,7 +384,6 @@
reg = <0x110b0000 0x10>;
#pwm-cells = <3>;
clocks = <&cru PCLK_PWM>;
- clock-names = "pwm";
pinctrl-names = "default";
pinctrl-0 = <&pwm0_pin>;
status = "disabled";
@@ -395,7 +394,6 @@
reg = <0x110b0010 0x10>;
#pwm-cells = <3>;
clocks = <&cru PCLK_PWM>;
- clock-names = "pwm";
pinctrl-names = "default";
pinctrl-0 = <&pwm1_pin>;
status = "disabled";
@@ -406,7 +404,6 @@
reg = <0x110b0020 0x10>;
#pwm-cells = <3>;
clocks = <&cru PCLK_PWM>;
- clock-names = "pwm";
pinctrl-names = "default";
pinctrl-0 = <&pwm2_pin>;
status = "disabled";
@@ -417,7 +414,6 @@
reg = <0x110b0030 0x10>;
#pwm-cells = <2>;
clocks = <&cru PCLK_PWM>;
- clock-names = "pwm";
pinctrl-names = "default";
pinctrl-0 = <&pwm3_pin>;
status = "disabled";
--
2.11.0

2021-05-14 12:31:31

by Heiko Stuebner

Subject: Re: [PATCH] ARM: dts: rockchip: Remove more clock-names from PWM nodes A test with the command below gives this error:

On Mon, 10 May 2021 19:29:11 +0200, Johan Jonker wrote:
> /arch/arm/boot/dts/rk3228-evb.dt.yaml:
> pwm@110b0020: clock-names: ['pwm'] is too short
>
> Devices with only one PWM clock use it to both to derive the functional
> clock for the device and as the bus clock. The driver does not need
> "clock-names" to get a handle, so remove them all.
>
> [...]

Applied, thanks!

[1/1] ARM: dts: rockchip: Remove more clock-names from PWM nodes A test with the command below gives this error:
commit: dc71c5ca34f408030b979d894c0459ef059445a1

Fixed the patch subject that somehow got mangled together with
the first line of the patch message.

Best regards,
--
Heiko Stuebner <[email protected]>