2021-05-08 19:38:45

by Corentin LABBE

Subject: [PATCH] dt-bindings: leds: common: add disk write/read and usb-host

The triggers enum misses 3 cases used by gemini DT.
usb-host was added via commit 0cfbd328d60f ("usb: Add LED triggers for USB activity")
so we add also as valid trigger usb-gadget which was added along in this
commit.

disk-read/disk-write were added by commit d1ed7c558612 ("leds: Extends disk trigger for reads and writes")

Signed-off-by: Corentin Labbe <[email protected]>
---
Documentation/devicetree/bindings/leds/common.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index b1f363747a62..a9b8c21779e3 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -89,6 +89,8 @@ properties:
- heartbeat
# LED indicates disk activity
- disk-activity
+ - disk-read
+ - disk-write
# LED indicates IDE disk activity (deprecated), in new implementations
# use "disk-activity"
- ide-disk
@@ -97,6 +99,8 @@ properties:
# LED alters the brightness for the specified duration with one software
# timer (requires "led-pattern" property)
- pattern
+ - usb-gadget
+ - usb-host

led-pattern:
description: |
--
2.26.3

2021-05-08 20:46:06

by Linus Walleij

Subject: Re: [PATCH] dt-bindings: leds: common: add disk write/read and usb-host

On Sat, May 8, 2021 at 9:37 PM Corentin Labbe <[email protected]> wrote:

> The triggers enum misses 3 cases used by gemini DT.
> usb-host was added via commit 0cfbd328d60f ("usb: Add LED triggers for USB activity")
> so we add also as valid trigger usb-gadget which was added along in this
> commit.
>
> disk-read/disk-write were added by commit d1ed7c558612 ("leds: Extends disk trigger for reads and writes")
>
> Signed-off-by: Corentin Labbe <[email protected]>

Good catch!
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2021-05-12 20:38:00

by Rob Herring

Subject: Re: [PATCH] dt-bindings: leds: common: add disk write/read and usb-host

On Sat, 08 May 2021 19:36:54 +0000, Corentin Labbe wrote:
> The triggers enum misses 3 cases used by gemini DT.
> usb-host was added via commit 0cfbd328d60f ("usb: Add LED triggers for USB activity")
> so we add also as valid trigger usb-gadget which was added along in this
> commit.
>
> disk-read/disk-write were added by commit d1ed7c558612 ("leds: Extends disk trigger for reads and writes")
>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> Documentation/devicetree/bindings/leds/common.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>

Acked-by: Rob Herring <[email protected]>