Allow users to implement shorter delays than a full second by implementing
msleep().
Signed-off-by: Mark Brown <[email protected]>
---
v2:
- Support delays of more than a second.
- Return the number of seconds remaining if the delay does not
complete.
tools/include/nolibc/nolibc.h | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/tools/include/nolibc/nolibc.h b/tools/include/nolibc/nolibc.h
index 8b7a9830dd22..01400d36ce99 100644
--- a/tools/include/nolibc/nolibc.h
+++ b/tools/include/nolibc/nolibc.h
@@ -2243,6 +2243,17 @@ unsigned int sleep(unsigned int seconds)
return 0;
}
+static __attribute__((unused))
+int msleep(unsigned int msecs)
+{
+ struct timeval my_timeval = { msecs / 1000, (msecs % 1000) * 1000 };
+
+ if (sys_select(0, 0, 0, 0, &my_timeval) < 0)
+ return my_timeval.tv_sec + !!my_timeval.tv_usec;
+ else
+ return 0;
+}
+
static __attribute__((unused))
int stat(const char *path, struct stat *buf)
{
--
2.20.1
On Wed, May 12, 2021 at 12:47:28PM +0100, Mark Brown wrote:
> Allow users to implement shorter delays than a full second by implementing
> msleep().
>
> Signed-off-by: Mark Brown <[email protected]>
> ---
>
> v2:
> - Support delays of more than a second.
> - Return the number of seconds remaining if the delay does not
> complete.
But why returning the number of seconds instead of milliseconds ?
The common use case is this:
delay = delay_before_next_event();
while ((ret = msleep(delay)) > 0)
delay -= ret;
Willy
On Wed, May 12, 2021 at 01:59:49PM +0200, Willy Tarreau wrote:
> On Wed, May 12, 2021 at 12:47:28PM +0100, Mark Brown wrote:
> > - Return the number of seconds remaining if the delay does not
> > complete.
> But why returning the number of seconds instead of milliseconds ?
> The common use case is this:
> delay = delay_before_next_event();
> while ((ret = msleep(delay)) > 0)
> delay -= ret;
It seemed to be what you were asking for and I didn't have strong enough
opinions for it to be worth pushing back.
On Wed, May 12, 2021 at 01:18:58PM +0100, Mark Brown wrote:
> On Wed, May 12, 2021 at 01:59:49PM +0200, Willy Tarreau wrote:
> > On Wed, May 12, 2021 at 12:47:28PM +0100, Mark Brown wrote:
>
> > > - Return the number of seconds remaining if the delay does not
> > > complete.
>
> > But why returning the number of seconds instead of milliseconds ?
> > The common use case is this:
>
> > delay = delay_before_next_event();
> > while ((ret = msleep(delay)) > 0)
> > delay -= ret;
>
> It seemed to be what you were asking for and I didn't have strong enough
> opinions for it to be worth pushing back.
Sorry if I wasn't clear then, but I proposed this example which should
return the number of ms left:
if (sys_select(0, 0, 0, 0, &my_timeval) < 0)
return my_timeval.tv_sec * 1000 + (my_timeval.tv_usec + 999) / 1000;
else
return 0;
In any case all of this is not critical but I'm fairly convinced that
your addition is useful, especially if done like this, which is why I
was asking.
Willy
On Wed, May 12, 2021 at 02:50:00PM +0200, Willy Tarreau wrote:
> Sorry if I wasn't clear then, but I proposed this example which should
> return the number of ms left:
Oh, I think what happened is that I took your "copying what we're doing
in sleep()" a bit too literally and didn't properly read the code you
added :/