Adding a cbas support for kukui platforms which has a tablet mode
switch through cros-ec interface.
---
Sorry for resending v7, I found some CCs were missing
and errata in email addresses.
Changes in v7:
- remove a label in cbas node in mt8183-kukui.dtsi
- fix an erratum in commit message (table --> tablet)
- dt-binding patche merged altogether with mt8183 dts
Changes in v6:
- Remove a label for cbas node in a example of dt-binding doc
Changes in v5:
- Add missing blank lines and change the description property's position.
- Add a note to description: "this device cannot be detected at runtime."
Changes in v4:
- Define cros-cbase bindings inside google,cros-ec.yaml instead of
a separated binding document.
Ikjoon Jang (2):
mfd: google,cros-ec: add DT bindings for a baseboard's switch device
arm64: dts: mt8183: add cbas node under cros_ec
.../bindings/mfd/google,cros-ec.yaml | 20 +++++++++++++++++++
.../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
2 files changed, 24 insertions(+)
--
2.31.1.751.gd2f1c929bd-goog
This is for ChromeOS tablets which have a 'cros_cbas' switch device
in the "Whiskers" base board. This device can be instantiated only by
device tree on ARM platforms. ChromeOS EC doesn't provide a way to
probe the device.
Signed-off-by: Ikjoon Jang <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
Acked-by: Enric Balletbo i Serra <[email protected]>
---
Changes in v7:
- no changes from v6
Changes in v6:
- Remove a label for cbas node in a example
Changes in v5:
- Add missing blank lines and change the description property's position.
- Add a note to description: "this device cannot be detected at runtime."
Changes in v4:
Define cros-cbase bindings inside google,cros-ec.yaml instead of
a separated binding document.
.../bindings/mfd/google,cros-ec.yaml | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
index 76bf16ee27ec..929c17552d8b 100644
--- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
+++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
@@ -114,6 +114,22 @@ properties:
- "#address-cells"
- "#size-cells"
+ cbas:
+ type: object
+
+ description:
+ This device is used to signal when a detachable base is attached
+ to a Chrome OS tablet. This device cannot be detected at runtime.
+
+ properties:
+ compatible:
+ const: google,cros-cbas
+
+ required:
+ - compatible
+
+ additionalProperties: false
+
patternProperties:
"^i2c-tunnel[0-9]*$":
type: object
@@ -180,6 +196,10 @@ examples:
interrupts = <99 0>;
interrupt-parent = <&gpio7>;
spi-max-frequency = <5000000>;
+
+ cbas {
+ compatible = "google,cros-cbas";
+ };
};
};
--
2.31.1.751.gd2f1c929bd-goog
Add a 'cbas' device node for supporting tablet mode switch in
kukui devices.
Kukui platforms with detacheable base have an additional input
device under cros-ec, which reports SW_TABLET_MODE regarding
its base state (e.g. base flipped or detached).
Signed-off-by: Ikjoon Jang <[email protected]>
---
Changes in v7:
- remove a label in cbas node
- fix an erratum in commit message (table --> tablet)
- dt-binding patchess merged altogether with mt8183 dts
arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index ff56bcfa3370..1512605a438e 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -816,6 +816,10 @@ usbc_extcon: extcon0 {
compatible = "google,extcon-usbc-cros-ec";
google,usb-port-id = <0>;
};
+
+ cbas {
+ compatible = "google,cros-cbas";
+ };
};
};
--
2.31.1.751.gd2f1c929bd-goog
Hi Ikjoon,
Thank you for the patch.
On 14/5/21 14:20, Ikjoon Jang wrote:
> Add a 'cbas' device node for supporting tablet mode switch in
> kukui devices.
>
> Kukui platforms with detacheable base have an additional input
> device under cros-ec, which reports SW_TABLET_MODE regarding
> its base state (e.g. base flipped or detached).
>
> Signed-off-by: Ikjoon Jang <[email protected]>
>
Reviewed-by: Enric Balletbo i Serra <[email protected]>
> ---
>
> Changes in v7:
> - remove a label in cbas node
> - fix an erratum in commit message (table --> tablet)
> - dt-binding patchess merged altogether with mt8183 dts
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index ff56bcfa3370..1512605a438e 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -816,6 +816,10 @@ usbc_extcon: extcon0 {
> compatible = "google,extcon-usbc-cros-ec";
> google,usb-port-id = <0>;
> };
> +
> + cbas {
> + compatible = "google,cros-cbas";
> + };
> };
> };
>
>
Quoting Ikjoon Jang (2021-05-14 05:20:50)
> Add a 'cbas' device node for supporting tablet mode switch in
> kukui devices.
>
> Kukui platforms with detacheable base have an additional input
> device under cros-ec, which reports SW_TABLET_MODE regarding
> its base state (e.g. base flipped or detached).
>
> Signed-off-by: Ikjoon Jang <[email protected]>
>
> ---
Reviewed-by: Stephen Boyd <[email protected]>
Quoting Ikjoon Jang (2021-05-14 05:20:49)
> This is for ChromeOS tablets which have a 'cros_cbas' switch device
> in the "Whiskers" base board. This device can be instantiated only by
> device tree on ARM platforms. ChromeOS EC doesn't provide a way to
> probe the device.
>
> Signed-off-by: Ikjoon Jang <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
> Acked-by: Enric Balletbo i Serra <[email protected]>
>
> ---
Reviewed-by: Stephen Boyd <[email protected]>
Hi Ikjoon,
Thank you for the patch.
On 14/5/21 14:20, Ikjoon Jang wrote:
> Add a 'cbas' device node for supporting tablet mode switch in
> kukui devices.
>
> Kukui platforms with detacheable base have an additional input
> device under cros-ec, which reports SW_TABLET_MODE regarding
> its base state (e.g. base flipped or detached).
>
> Signed-off-by: Ikjoon Jang <[email protected]>
>
Reviewed-by: Enric Balletbo i Serra <[email protected]>
> ---
>
> Changes in v7:
> - remove a label in cbas node
> - fix an erratum in commit message (table --> tablet)
> - dt-binding patchess merged altogether with mt8183 dts
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index ff56bcfa3370..1512605a438e 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -816,6 +816,10 @@ usbc_extcon: extcon0 {
> compatible = "google,extcon-usbc-cros-ec";
> google,usb-port-id = <0>;
> };
> +
> + cbas {
> + compatible = "google,cros-cbas";
> + };
> };
> };
>
>