2021-05-19 12:22:19

by Yang Yingliang

Subject: [PATCH -next] virtio_ring: Correct function name virtqueue_get_buf_ctx()

Fix the following make W=1 kernel build warning:

drivers/virtio/virtio_ring.c:1903: warning: expecting prototype for virtqueue_get_buf(). Prototype was for virtqueue_get_buf_ctx() instead

Signed-off-by: Yang Yingliang <[email protected]>
---
drivers/virtio/virtio_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index 88f0b16b11b8..992cb1cbec93 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -1882,7 +1882,7 @@ bool virtqueue_kick(struct virtqueue *vq)
EXPORT_SYMBOL_GPL(virtqueue_kick);

/**
- * virtqueue_get_buf - get the next used buffer
+ * virtqueue_get_buf_ctx - get the next used buffer
* @_vq: the struct virtqueue we're talking about.
* @len: the length written into the buffer
* @ctx: extra context for the token
--
2.25.1

2021-05-20 07:30:28

by Stefano Garzarella

Subject: Re: [PATCH -next] virtio_ring: Correct function name virtqueue_get_buf_ctx()

On Tue, May 18, 2021 at 01:00:57PM +0800, Yang Yingliang wrote:
>Fix the following make W=1 kernel build warning:
>
> drivers/virtio/virtio_ring.c:1903: warning: expecting prototype for virtqueue_get_buf(). Prototype was for virtqueue_get_buf_ctx() instead
>
>Signed-off-by: Yang Yingliang <[email protected]>
>---
> drivers/virtio/virtio_ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
>index 88f0b16b11b8..992cb1cbec93 100644
>--- a/drivers/virtio/virtio_ring.c
>+++ b/drivers/virtio/virtio_ring.c
>@@ -1882,7 +1882,7 @@ bool virtqueue_kick(struct virtqueue *vq)
> EXPORT_SYMBOL_GPL(virtqueue_kick);
>
> /**
>- * virtqueue_get_buf - get the next used buffer
>+ * virtqueue_get_buf_ctx - get the next used buffer
> * @_vq: the struct virtqueue we're talking about.
> * @len: the length written into the buffer
> * @ctx: extra context for the token
>--
>2.25.1
>

Reviewed-by: Stefano Garzarella <[email protected]>

2021-05-25 01:33:08

by Jason Wang

Subject: Re: [PATCH -next] virtio_ring: Correct function name virtqueue_get_buf_ctx()

?? 2021/5/18 ????1:00, Yang Yingliang д??:
> Fix the following make W=1 kernel build warning:
>
> drivers/virtio/virtio_ring.c:1903: warning: expecting prototype for virtqueue_get_buf(). Prototype was for virtqueue_get_buf_ctx() instead
>
> Signed-off-by: Yang Yingliang <[email protected]>
> ---
> drivers/virtio/virtio_ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 88f0b16b11b8..992cb1cbec93 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -1882,7 +1882,7 @@ bool virtqueue_kick(struct virtqueue *vq)
> EXPORT_SYMBOL_GPL(virtqueue_kick);
>
> /**
> - * virtqueue_get_buf - get the next used buffer
> + * virtqueue_get_buf_ctx - get the next used buffer
> * @_vq: the struct virtqueue we're talking about.
> * @len: the length written into the buffer
> * @ctx: extra context for the token


Acked-by: Jason Wang <[email protected]>