The AXP305 PMIC used in AXP805 seems to be fully compatible to the
AXP805 PMIC, so add the proper chain of compatible strings.
Also at least on one board (Orangepi Zero2) there is no interrupt line
connected to the CPU, so make the "interrupts" property optional.
Signed-off-by: Andre Przywara <[email protected]>
---
Documentation/devicetree/bindings/mfd/axp20x.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt
index 4991a6415796..4fd748101e3c 100644
--- a/Documentation/devicetree/bindings/mfd/axp20x.txt
+++ b/Documentation/devicetree/bindings/mfd/axp20x.txt
@@ -26,10 +26,10 @@ Required properties:
* "x-powers,axp803"
* "x-powers,axp806"
* "x-powers,axp805", "x-powers,axp806"
+ * "x-powers,axp803", "x-powers,axp805", "x-powers,axp806"
* "x-powers,axp809"
* "x-powers,axp813"
- reg: The I2C slave address or RSB hardware address for the AXP chip
-- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin
- interrupt-controller: The PMIC has its own internal IRQs
- #interrupt-cells: Should be set to 1
@@ -43,6 +43,7 @@ more information:
AXP20x/LDO3: software-based implementation
Optional properties:
+- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin
- x-powers,dcdc-freq: defines the work frequency of DC-DC in KHz
AXP152/20X: range: 750-1875, Default: 1.5 MHz
AXP22X/8XX: range: 1800-4050, Default: 3 MHz
--
2.17.5
On Wed, May 19, 2021 at 11:41:36AM +0100, Andre Przywara wrote:
> The AXP305 PMIC used in AXP805 seems to be fully compatible to the
> AXP805 PMIC, so add the proper chain of compatible strings.
>
> Also at least on one board (Orangepi Zero2) there is no interrupt line
> connected to the CPU, so make the "interrupts" property optional.
>
> Signed-off-by: Andre Przywara <[email protected]>
> ---
> Documentation/devicetree/bindings/mfd/axp20x.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Don't you want to convert this to schema? It's one of the last warnings
for sunxi IIRC.
Acked-by: Rob Herring <[email protected]>
>
> diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt
> index 4991a6415796..4fd748101e3c 100644
> --- a/Documentation/devicetree/bindings/mfd/axp20x.txt
> +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt
> @@ -26,10 +26,10 @@ Required properties:
> * "x-powers,axp803"
> * "x-powers,axp806"
> * "x-powers,axp805", "x-powers,axp806"
> + * "x-powers,axp803", "x-powers,axp805", "x-powers,axp806"
> * "x-powers,axp809"
> * "x-powers,axp813"
> - reg: The I2C slave address or RSB hardware address for the AXP chip
> -- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin
> - interrupt-controller: The PMIC has its own internal IRQs
> - #interrupt-cells: Should be set to 1
>
> @@ -43,6 +43,7 @@ more information:
> AXP20x/LDO3: software-based implementation
>
> Optional properties:
> +- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin
> - x-powers,dcdc-freq: defines the work frequency of DC-DC in KHz
> AXP152/20X: range: 750-1875, Default: 1.5 MHz
> AXP22X/8XX: range: 1800-4050, Default: 3 MHz
> --
> 2.17.5
>
On 5/19/21 5:41 AM, Andre Przywara wrote:
> The AXP305 PMIC used in AXP805 seems to be fully compatible to the
^^^^^^^^^^^^^^
Typo? Do you mean "used with the H616 SoC"?
> AXP805 PMIC, so add the proper chain of compatible strings.
>
> Also at least on one board (Orangepi Zero2) there is no interrupt line
> connected to the CPU, so make the "interrupts" property optional.
>
> Signed-off-by: Andre Przywara <[email protected]>
> ---
> Documentation/devicetree/bindings/mfd/axp20x.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt
> index 4991a6415796..4fd748101e3c 100644
> --- a/Documentation/devicetree/bindings/mfd/axp20x.txt
> +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt
> @@ -26,10 +26,10 @@ Required properties:
> * "x-powers,axp803"
> * "x-powers,axp806"
> * "x-powers,axp805", "x-powers,axp806"
> + * "x-powers,axp803", "x-powers,axp805", "x-powers,axp806"
^^^^^^
This should be x-powers,axp305.
Regards,
Samuel
> * "x-powers,axp809"
> * "x-powers,axp813"
> - reg: The I2C slave address or RSB hardware address for the AXP chip
> -- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin
> - interrupt-controller: The PMIC has its own internal IRQs
> - #interrupt-cells: Should be set to 1
>
> @@ -43,6 +43,7 @@ more information:
> AXP20x/LDO3: software-based implementation
>
> Optional properties:
> +- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin
> - x-powers,dcdc-freq: defines the work frequency of DC-DC in KHz
> AXP152/20X: range: 750-1875, Default: 1.5 MHz
> AXP22X/8XX: range: 1800-4050, Default: 3 MHz
>
On Sat, 22 May 2021 09:46:23 -0500
Samuel Holland <[email protected]> wrote:
> On 5/19/21 5:41 AM, Andre Przywara wrote:
> > The AXP305 PMIC used in AXP805 seems to be fully compatible to the
> ^^^^^^^^^^^^^^
> Typo? Do you mean "used with the H616 SoC"?
Ouch, yes. And even more embarrassingly Chen-Yu pointed that out already
in the previous version. Same for the compatible string.
Thanks for having a look!
Cheers,
Andre
>
> > AXP805 PMIC, so add the proper chain of compatible strings.
> >
> > Also at least on one board (Orangepi Zero2) there is no interrupt line
> > connected to the CPU, so make the "interrupts" property optional.
> >
> > Signed-off-by: Andre Przywara <[email protected]>
> > ---
> > Documentation/devicetree/bindings/mfd/axp20x.txt | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt
> > index 4991a6415796..4fd748101e3c 100644
> > --- a/Documentation/devicetree/bindings/mfd/axp20x.txt
> > +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt
> > @@ -26,10 +26,10 @@ Required properties:
> > * "x-powers,axp803"
> > * "x-powers,axp806"
> > * "x-powers,axp805", "x-powers,axp806"
> > + * "x-powers,axp803", "x-powers,axp805", "x-powers,axp806"
> ^^^^^^
> This should be x-powers,axp305.
>
> Regards,
> Samuel
>
> > * "x-powers,axp809"
> > * "x-powers,axp813"
> > - reg: The I2C slave address or RSB hardware address for the AXP chip
> > -- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin
> > - interrupt-controller: The PMIC has its own internal IRQs
> > - #interrupt-cells: Should be set to 1
> >
> > @@ -43,6 +43,7 @@ more information:
> > AXP20x/LDO3: software-based implementation
> >
> > Optional properties:
> > +- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin
> > - x-powers,dcdc-freq: defines the work frequency of DC-DC in KHz
> > AXP152/20X: range: 750-1875, Default: 1.5 MHz
> > AXP22X/8XX: range: 1800-4050, Default: 3 MHz
> >
>
>