2021-05-24 15:25:56

by Aswath Govindraju

[permalink] [raw]
Subject: [PATCH v3 0/2] dt-bindings: gpio: davinci: Convert to json-schema

Convert the davinci GPIO device tree binding documentation to json-schema.
The GPIO hog node names are defined to end with a 'hog' suffix.

All existing GPIO hogs are fixed to follow above naming convention
before changing the binding to avoid dtbs_check warnings.

changes since v2:
- Used gpio-hog.yaml for gpio-hog property
- Added constraints on gpio-hog node name
- Corrected the gpio hog dt node names to align
with the dt-schema

changes since v1:
- combined the individual compatible properties into one enum
- added maxItems and minItems properties for gpio-line-names and
interrupts
- updated the description of interrupts property
- removed the description for properties that are general
- updated the pattern property for gpio hog to indicate any sort
node name based on its usage
- corrected the example wakeup gpio node name

Aswath Govindraju (2):
ARM: dts: da850-lego-ev3: align GPIO hog names with dt-schema
dt-bindings: gpio: gpio-davinci: Convert to json-schema

.../devicetree/bindings/gpio/gpio-davinci.txt | 167 ----------------
.../bindings/gpio/gpio-davinci.yaml | 186 ++++++++++++++++++
MAINTAINERS | 2 +-
arch/arm/boot/dts/da850-lego-ev3.dts | 10 +-
4 files changed, 192 insertions(+), 173 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-davinci.txt
create mode 100644 Documentation/devicetree/bindings/gpio/gpio-davinci.yaml

--
2.17.1


2021-05-24 15:27:31

by Aswath Govindraju

[permalink] [raw]
Subject: [PATCH v3 1/2] ARM: dts: da850-lego-ev3: align GPIO hog names with dt-schema

The GPIO hog dt-schema node naming convention expect GPIO hogs node names
to end with a 'hog' suffix.

Signed-off-by: Aswath Govindraju <[email protected]>
---
arch/arm/boot/dts/da850-lego-ev3.dts | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/da850-lego-ev3.dts b/arch/arm/boot/dts/da850-lego-ev3.dts
index afd04a423856..1e86cde86406 100644
--- a/arch/arm/boot/dts/da850-lego-ev3.dts
+++ b/arch/arm/boot/dts/da850-lego-ev3.dts
@@ -412,14 +412,14 @@
status = "okay";

/* Don't pull down battery voltage adc io channel */
- batt_volt_en {
+ batt-volt-en-hog {
gpio-hog;
gpios = <6 GPIO_ACTIVE_HIGH>;
output-high;
};

/* Don't impede Bluetooth clock signal */
- bt_clock_en {
+ bt-clock-en-hog {
gpio-hog;
gpios = <5 GPIO_ACTIVE_HIGH>;
input;
@@ -433,19 +433,19 @@
* anything, but they are present in the source code from LEGO.
*/

- bt_pic_en {
+ bt-pic-en-hog {
gpio-hog;
gpios = <51 GPIO_ACTIVE_HIGH>;
output-low;
};

- bt_pic_rst {
+ bt-pic-rst-hog {
gpio-hog;
gpios = <78 GPIO_ACTIVE_HIGH>;
output-high;
};

- bt_pic_cts {
+ bt-pic-cts-hog {
gpio-hog;
gpios = <87 GPIO_ACTIVE_HIGH>;
input;
--
2.17.1

2021-05-24 16:17:38

by David Lechner

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] ARM: dts: da850-lego-ev3: align GPIO hog names with dt-schema

On 5/24/21 10:19 AM, Aswath Govindraju wrote:
> The GPIO hog dt-schema node naming convention expect GPIO hogs node names
> to end with a 'hog' suffix.
>
> Signed-off-by: Aswath Govindraju <[email protected]>
> ---

Acked-by: David Lechner <[email protected]>


2021-06-20 07:32:11

by Aswath Govindraju

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] dt-bindings: gpio: davinci: Convert to json-schema

Hi Bart, Linus,

On 24/05/21 8:49 pm, Aswath Govindraju wrote:
> Convert the davinci GPIO device tree binding documentation to json-schema.
> The GPIO hog node names are defined to end with a 'hog' suffix.
>
> All existing GPIO hogs are fixed to follow above naming convention
> before changing the binding to avoid dtbs_check warnings.
>
> changes since v2:
> - Used gpio-hog.yaml for gpio-hog property
> - Added constraints on gpio-hog node name
> - Corrected the gpio hog dt node names to align
> with the dt-schema
>

May I know if the following series is okay to be merged ?

Thanks,
Aswath

> changes since v1:
> - combined the individual compatible properties into one enum
> - added maxItems and minItems properties for gpio-line-names and
> interrupts
> - updated the description of interrupts property
> - removed the description for properties that are general
> - updated the pattern property for gpio hog to indicate any sort
> node name based on its usage
> - corrected the example wakeup gpio node name
>
> Aswath Govindraju (2):
> ARM: dts: da850-lego-ev3: align GPIO hog names with dt-schema
> dt-bindings: gpio: gpio-davinci: Convert to json-schema
>
> .../devicetree/bindings/gpio/gpio-davinci.txt | 167 ----------------
> .../bindings/gpio/gpio-davinci.yaml | 186 ++++++++++++++++++
> MAINTAINERS | 2 +-
> arch/arm/boot/dts/da850-lego-ev3.dts | 10 +-
> 4 files changed, 192 insertions(+), 173 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-davinci.txt
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
>

2021-06-21 11:50:33

by Bartosz Golaszewski

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] dt-bindings: gpio: davinci: Convert to json-schema

On Sun, Jun 20, 2021 at 9:29 AM Aswath Govindraju <[email protected]> wrote:
>
> Hi Bart, Linus,
>
> On 24/05/21 8:49 pm, Aswath Govindraju wrote:
> > Convert the davinci GPIO device tree binding documentation to json-schema.
> > The GPIO hog node names are defined to end with a 'hog' suffix.
> >
> > All existing GPIO hogs are fixed to follow above naming convention
> > before changing the binding to avoid dtbs_check warnings.
> >
> > changes since v2:
> > - Used gpio-hog.yaml for gpio-hog property
> > - Added constraints on gpio-hog node name
> > - Corrected the gpio hog dt node names to align
> > with the dt-schema
> >
>
> May I know if the following series is okay to be merged ?
>
> Thanks,
> Aswath
>

I applied the dt-bindings patch. Sekhar normally takes DTS patches for davinci.

Bart