2021-06-01 09:03:29

by Neil Armstrong

[permalink] [raw]
Subject: [PATCH 2/6] arm64: dts: meson-sm1-odroid: set tf_io regulator gpio as open source

According to Odroid-C4 & HC4 Schematics, the TF_3V3N_1V8_EN can be in Hi-Z for 3v3,
and since it's the default GPIOAO_6 mode at reset, let switch this GPIO as Open-Source
to drive for 1, and input for 0.

Fixes: 88d537bc92ca ("arm64: dts: meson: convert meson-sm1-odroid-c4 to dtsi")
Signed-off-by: Neil Armstrong <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi
index af40ba461074..e64359163331 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi
@@ -52,7 +52,7 @@ tf_io: gpio-regulator-tf_io {
enable-active-high;
regulator-always-on;

- gpios = <&gpio_ao GPIOAO_6 GPIO_ACTIVE_HIGH>;
+ gpios = <&gpio_ao GPIOAO_6 GPIO_OPEN_SOURCE>;
gpios-states = <0>;

states = <3300000 0>,
--
2.25.1


2021-06-03 18:07:28

by Martin Blumenstingl

[permalink] [raw]
Subject: Re: [PATCH 2/6] arm64: dts: meson-sm1-odroid: set tf_io regulator gpio as open source

On Tue, Jun 1, 2021 at 11:01 AM Neil Armstrong <[email protected]> wrote:
>
> According to Odroid-C4 & HC4 Schematics, the TF_3V3N_1V8_EN can be in Hi-Z for 3v3,
> and since it's the default GPIOAO_6 mode at reset, let switch this GPIO as Open-Source
> to drive for 1, and input for 0.
>
> Fixes: 88d537bc92ca ("arm64: dts: meson: convert meson-sm1-odroid-c4 to dtsi")
> Signed-off-by: Neil Armstrong <[email protected]>
Acked-by: Martin Blumenstingl <[email protected]>