2021-06-01 09:10:35

by Zhen Lei

Subject: [PATCH 1/1] video: fbdev: mb862xx: use DEVICE_ATTR_RO macro

Use DEVICE_ATTR_RO helper instead of plain DEVICE_ATTR, which makes the
code a bit shorter and easier to read.

Signed-off-by: Zhen Lei <[email protected]>
---
drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
index 52755b591c1489f..63721337a37787b 100644
--- a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
+++ b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
@@ -542,8 +542,8 @@ static int mb862xxfb_init_fbinfo(struct fb_info *fbi)
/*
* show some display controller and cursor registers
*/
-static ssize_t mb862xxfb_show_dispregs(struct device *dev,
- struct device_attribute *attr, char *buf)
+static ssize_t dispregs_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
{
struct fb_info *fbi = dev_get_drvdata(dev);
struct mb862xxfb_par *par = fbi->par;
@@ -577,7 +577,7 @@ static ssize_t mb862xxfb_show_dispregs(struct device *dev,
return ptr - buf;
}

-static DEVICE_ATTR(dispregs, 0444, mb862xxfb_show_dispregs, NULL);
+static DEVICE_ATTR_RO(dispregs);

static irqreturn_t mb862xx_intr(int irq, void *dev_id)
{
--
2.26.0.106.g9fadedd

2021-06-01 16:13:25

by Daniel Vetter

Subject: Re: [PATCH 1/1] video: fbdev: mb862xx: use DEVICE_ATTR_RO macro

On Tue, Jun 01, 2021 at 05:08:52PM +0800, Zhen Lei wrote:
> Use DEVICE_ATTR_RO helper instead of plain DEVICE_ATTR, which makes the
> code a bit shorter and easier to read.
>
> Signed-off-by: Zhen Lei <[email protected]>

Applied to drm-misc-next, thanks.
-Daniel

> ---
> drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> index 52755b591c1489f..63721337a37787b 100644
> --- a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> +++ b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> @@ -542,8 +542,8 @@ static int mb862xxfb_init_fbinfo(struct fb_info *fbi)
> /*
> * show some display controller and cursor registers
> */
> -static ssize_t mb862xxfb_show_dispregs(struct device *dev,
> - struct device_attribute *attr, char *buf)
> +static ssize_t dispregs_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> {
> struct fb_info *fbi = dev_get_drvdata(dev);
> struct mb862xxfb_par *par = fbi->par;
> @@ -577,7 +577,7 @@ static ssize_t mb862xxfb_show_dispregs(struct device *dev,
> return ptr - buf;
> }
>
> -static DEVICE_ATTR(dispregs, 0444, mb862xxfb_show_dispregs, NULL);
> +static DEVICE_ATTR_RO(dispregs);
>
> static irqreturn_t mb862xx_intr(int irq, void *dev_id)
> {
> --
> 2.26.0.106.g9fadedd
>
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch