2021-06-08 03:07:22

by Baokun Li

Subject: [PATCH -next] gfs2: Use list_move_tail instead of list_del/list_add_tail

Using list_move_tail() instead of list_del() + list_add_tail().

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Baokun Li <[email protected]>
---
fs/gfs2/glock.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index f6cae2ee1c83..902dd7385462 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -212,8 +212,7 @@ void gfs2_glock_add_to_lru(struct gfs2_glock *gl)

spin_lock(&lru_lock);

- list_del(&gl->gl_lru);
- list_add_tail(&gl->gl_lru, &lru_list);
+ list_move_tail(&gl->gl_lru, &lru_list);

if (!test_bit(GLF_LRU, &gl->gl_flags)) {
set_bit(GLF_LRU, &gl->gl_flags);

2021-06-09 17:18:45

by Andreas Gruenbacher

Subject: Re: [PATCH -next] gfs2: Use list_move_tail instead of list_del/list_add_tail

On Tue, Jun 8, 2021 at 5:23 AM Baokun Li <[email protected]> wrote:
> Using list_move_tail() instead of list_del() + list_add_tail().

Thanks, I'll add that to for-next.

Andreas