2021-06-09 13:25:18

by Baokun Li

[permalink] [raw]
Subject: [PATCH net-next v2] nfp: use list_move instead of list_del/list_add in nfp_cppcore.c

Using list_move() instead of list_del() + list_add() in nfp_cppcore.c.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Baokun Li <[email protected]>
---
V1->V2:
CC mailist

.../ethernet/netronome/nfp/nfpcore/nfp_cppcore.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cppcore.c b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cppcore.c
index 94994a939277..d7ac0307797f 100644
--- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cppcore.c
+++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cppcore.c
@@ -905,8 +905,7 @@ area_cache_put(struct nfp_cpp *cpp, struct nfp_cpp_area_cache *cache)
return;

/* Move to front of LRU */
- list_del(&cache->entry);
- list_add(&cache->entry, &cpp->area_cache_list);
+ list_move(&cache->entry, &cpp->area_cache_list);

mutex_unlock(&cpp->area_cache_mutex);
}


2021-06-09 17:13:41

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH net-next v2] nfp: use list_move instead of list_del/list_add in nfp_cppcore.c

On Wed, Jun 09, 2021 at 03:09:21PM +0800, Baokun Li wrote:
> Using list_move() instead of list_del() + list_add() in nfp_cppcore.c.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Baokun Li <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

2021-06-09 21:15:33

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net-next v2] nfp: use list_move instead of list_del/list_add in nfp_cppcore.c

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 9 Jun 2021 15:09:21 +0800 you wrote:
> Using list_move() instead of list_del() + list_add() in nfp_cppcore.c.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Baokun Li <[email protected]>
> ---
> V1->V2:
> CC mailist
>
> [...]

Here is the summary with links:
- [net-next,v2] nfp: use list_move instead of list_del/list_add in nfp_cppcore.c
https://git.kernel.org/netdev/net-next/c/39c3783ec062

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html