2021-06-09 21:05:24

by kernel test robot

[permalink] [raw]
Subject: fs/nfsd/nfs4xdr.c:4657 nfsd4_encode_read_plus_hole() warn: inconsistent indenting

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 368094df48e680fa51cedb68537408cfa64b788e
commit: 2db27992dd565bf400658edc18f67aed0b6bc6cb NFSD: Add READ_PLUS hole segment encoding
date: 8 months ago
config: h8300-randconfig-m031-20210609 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

New smatch warnings:
fs/nfsd/nfs4xdr.c:4657 nfsd4_encode_read_plus_hole() warn: inconsistent indenting

Old smatch warnings:
fs/nfsd/nfs4xdr.c:679 nfsd4_decode_close() warn: ignoring unreachable code.

vim +4657 fs/nfsd/nfs4xdr.c

4642
4643 static __be32
4644 nfsd4_encode_read_plus_hole(struct nfsd4_compoundres *resp,
4645 struct nfsd4_read *read,
4646 unsigned long maxcount, u32 *eof)
4647 {
4648 struct file *file = read->rd_nf->nf_file;
4649 __be32 *p;
4650
4651 /* Content type, offset, byte count */
4652 p = xdr_reserve_space(&resp->xdr, 4 + 8 + 8);
4653 if (!p)
4654 return nfserr_resource;
4655
4656 *p++ = htonl(NFS4_CONTENT_HOLE);
> 4657 p = xdr_encode_hyper(p, read->rd_offset);
4658 p = xdr_encode_hyper(p, maxcount);
4659
4660 *eof = (read->rd_offset + maxcount) >= i_size_read(file_inode(file));
4661 return nfs_ok;
4662 }
4663

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]


Attachments:
(No filename) (1.50 kB)
.config.gz (27.38 kB)
Download all attachments