2021-06-11 07:26:34

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] crypto: cavium/nitrox - Fix an erro rhandling path in 'nitrox_probe()'

On Sat, Jun 05, 2021 at 02:55:56PM +0200, Christophe JAILLET wrote:
> If an error occurs after a successful 'ioremap()' call, it must be undone
> by a corresponding 'iounmap()' call, as already done in the remove
> function.
> Ass a 'pf_sw_fail' label in the error handling path and add the missing
> 'iounmap()'.
>
> While at it, also add a 'flr_fail' label in the error handling path and use
> it to avoid some code duplication.
>
> Fixes: 14fa93cdcd9b ("crypto: cavium - Add support for CNN55XX adapters.")
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> drivers/crypto/cavium/nitrox/nitrox_main.c | 17 ++++++++---------
> 1 file changed, 8 insertions(+), 9 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt