2021-06-12 12:38:18

by Yury Norov

Subject: [PATCH 1/8] bitops: protect find_first_{,zero}_bit properly

find_first_bit() and find_first_zero_bit() are not protected with
ifdefs as other functions in find.h. It causes build errors on some
platforms if CONFIG_GENERIC_FIND_FIRST_BIT is enabled.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Yury Norov <[email protected]>
---
include/asm-generic/bitops/find.h | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/include/asm-generic/bitops/find.h b/include/asm-generic/bitops/find.h
index 0d132ee2a291..835f959a25f2 100644
--- a/include/asm-generic/bitops/find.h
+++ b/include/asm-generic/bitops/find.h
@@ -97,6 +97,7 @@ unsigned long find_next_zero_bit(const unsigned long *addr, unsigned long size,

#ifdef CONFIG_GENERIC_FIND_FIRST_BIT

+#ifndef find_first_bit
/**
* find_first_bit - find the first set bit in a memory region
* @addr: The address to start the search at
@@ -116,7 +117,9 @@ unsigned long find_first_bit(const unsigned long *addr, unsigned long size)

return _find_first_bit(addr, size);
}
+#endif

+#ifndef find_first_zero_bit
/**
* find_first_zero_bit - find the first cleared bit in a memory region
* @addr: The address to start the search at
@@ -136,6 +139,8 @@ unsigned long find_first_zero_bit(const unsigned long *addr, unsigned long size)

return _find_first_zero_bit(addr, size);
}
+#endif
+
#else /* CONFIG_GENERIC_FIND_FIRST_BIT */

#ifndef find_first_bit
--
2.30.2

2021-06-12 21:44:10

by Andy Shevchenko

Subject: Re: [PATCH 1/8] bitops: protect find_first_{,zero}_bit properly

On Sat, Jun 12, 2021 at 3:38 PM Yury Norov <[email protected]> wrote:
>
> find_first_bit() and find_first_zero_bit() are not protected with
> ifdefs as other functions in find.h. It causes build errors on some
> platforms if CONFIG_GENERIC_FIND_FIRST_BIT is enabled.

Fixes?

> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Yury Norov <[email protected]>


--
With Best Regards,
Andy Shevchenko

2021-06-29 01:33:06

by Yury Norov

Subject: Re: [PATCH 1/8] bitops: protect find_first_{,zero}_bit properly

On Sun, Jun 13, 2021 at 12:38:52AM +0300, Andy Shevchenko wrote:
> On Sat, Jun 12, 2021 at 3:38 PM Yury Norov <[email protected]> wrote:
> >
> > find_first_bit() and find_first_zero_bit() are not protected with
> > ifdefs as other functions in find.h. It causes build errors on some
> > platforms if CONFIG_GENERIC_FIND_FIRST_BIT is enabled.
>
> Fixes?

Fixes: 2cc7b6a44ac2 ("lib: add fast path for find_first_*_bit() and find_last_bit()")

> > Reported-by: kernel test robot <[email protected]>
> > Signed-off-by: Yury Norov <[email protected]>