2021-06-14 14:58:35

by J. Bruce Fields

[permalink] [raw]
Subject: Re: [PATCH] rpc: remove redundant initialization of variable status

Thanks, applied.--b.

On Sun, Jun 13, 2021 at 03:06:52PM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable status is being initialized with a value that is never
> read, the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> net/sunrpc/auth_gss/svcauth_gss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
> index 6dff64374bfe..a81be45f40d9 100644
> --- a/net/sunrpc/auth_gss/svcauth_gss.c
> +++ b/net/sunrpc/auth_gss/svcauth_gss.c
> @@ -1275,7 +1275,7 @@ static int gss_proxy_save_rsc(struct cache_detail *cd,
> long long ctxh;
> struct gss_api_mech *gm = NULL;
> time64_t expiry;
> - int status = -EINVAL;
> + int status;
>
> memset(&rsci, 0, sizeof(rsci));
> /* context handle */
> --
> 2.31.1