2021-06-14 15:47:16

by Marcin Juszkiewicz

Subject: [PATCH] quota: finish disable quotactl_path syscall

In commit 5b9fedb31e47 ("quota: Disable quotactl_path syscall") Jan Kara
disabled quotactl_path syscall on several architectures.

This commit disables it on all architectures using unified list of
system calls:

- arm64
- arc
- csky
- h8300
- hexagon
- nds32
- nios2
- openrisc
- riscv (32/64)

CC: Jan Kara <[email protected]>
CC: Christian Brauner <[email protected]>
CC: Sascha Hauer <[email protected]>
Link: https://lore.kernel.org/lkml/20210512153621.n5u43jsytbik4yze@wittgenstein

Signed-off-by: Marcin Juszkiewicz <[email protected]>
---
include/uapi/asm-generic/unistd.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
index 6de5a7fc066b..d2a942086fcb 100644
--- a/include/uapi/asm-generic/unistd.h
+++ b/include/uapi/asm-generic/unistd.h
@@ -863,8 +863,7 @@ __SYSCALL(__NR_process_madvise, sys_process_madvise)
__SC_COMP(__NR_epoll_pwait2, sys_epoll_pwait2, compat_sys_epoll_pwait2)
#define __NR_mount_setattr 442
__SYSCALL(__NR_mount_setattr, sys_mount_setattr)
-#define __NR_quotactl_path 443
-__SYSCALL(__NR_quotactl_path, sys_quotactl_path)
+/* 443 is reserved for quotactl_path */

#define __NR_landlock_create_ruleset 444
__SYSCALL(__NR_landlock_create_ruleset, sys_landlock_create_ruleset)
--
2.31.1

2021-06-14 16:46:10

by Jan Kara

Subject: Re: [PATCH] quota: finish disable quotactl_path syscall

On Mon 14-06-21 17:37:12, Marcin Juszkiewicz wrote:
> In commit 5b9fedb31e47 ("quota: Disable quotactl_path syscall") Jan Kara
> disabled quotactl_path syscall on several architectures.
>
> This commit disables it on all architectures using unified list of
> system calls:
>
> - arm64
> - arc
> - csky
> - h8300
> - hexagon
> - nds32
> - nios2
> - openrisc
> - riscv (32/64)
>
> CC: Jan Kara <[email protected]>
> CC: Christian Brauner <[email protected]>
> CC: Sascha Hauer <[email protected]>
> Link: https://lore.kernel.org/lkml/20210512153621.n5u43jsytbik4yze@wittgenstein
>
> Signed-off-by: Marcin Juszkiewicz <[email protected]>

Aha, I've missed that one. Thanks for catching this. Arnd, will you take
this patch or should I take it through my tree?

Honza

> ---
> include/uapi/asm-generic/unistd.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
> index 6de5a7fc066b..d2a942086fcb 100644
> --- a/include/uapi/asm-generic/unistd.h
> +++ b/include/uapi/asm-generic/unistd.h
> @@ -863,8 +863,7 @@ __SYSCALL(__NR_process_madvise, sys_process_madvise)
> __SC_COMP(__NR_epoll_pwait2, sys_epoll_pwait2, compat_sys_epoll_pwait2)
> #define __NR_mount_setattr 442
> __SYSCALL(__NR_mount_setattr, sys_mount_setattr)
> -#define __NR_quotactl_path 443
> -__SYSCALL(__NR_quotactl_path, sys_quotactl_path)
> +/* 443 is reserved for quotactl_path */
>
> #define __NR_landlock_create_ruleset 444
> __SYSCALL(__NR_landlock_create_ruleset, sys_landlock_create_ruleset)
> --
> 2.31.1
>
--
Jan Kara <[email protected]>
SUSE Labs, CR

2021-06-15 08:48:25

by Jan Kara

Subject: Re: [PATCH] quota: finish disable quotactl_path syscall

On Mon 14-06-21 18:44:54, Jan Kara wrote:
> On Mon 14-06-21 17:37:12, Marcin Juszkiewicz wrote:
> > In commit 5b9fedb31e47 ("quota: Disable quotactl_path syscall") Jan Kara
> > disabled quotactl_path syscall on several architectures.
> >
> > This commit disables it on all architectures using unified list of
> > system calls:
> >
> > - arm64
> > - arc
> > - csky
> > - h8300
> > - hexagon
> > - nds32
> > - nios2
> > - openrisc
> > - riscv (32/64)
> >
> > CC: Jan Kara <[email protected]>
> > CC: Christian Brauner <[email protected]>
> > CC: Sascha Hauer <[email protected]>
> > Link: https://lore.kernel.org/lkml/20210512153621.n5u43jsytbik4yze@wittgenstein
> >
> > Signed-off-by: Marcin Juszkiewicz <[email protected]>
>
> Aha, I've missed that one. Thanks for catching this. Arnd, will you take
> this patch or should I take it through my tree?

OK, I want this to make it for rc7 so I've pulled this patch to my tree and
will push it to Linus in a few days.

Honza

> > diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
> > index 6de5a7fc066b..d2a942086fcb 100644
> > --- a/include/uapi/asm-generic/unistd.h
> > +++ b/include/uapi/asm-generic/unistd.h
> > @@ -863,8 +863,7 @@ __SYSCALL(__NR_process_madvise, sys_process_madvise)
> > __SC_COMP(__NR_epoll_pwait2, sys_epoll_pwait2, compat_sys_epoll_pwait2)
> > #define __NR_mount_setattr 442
> > __SYSCALL(__NR_mount_setattr, sys_mount_setattr)
> > -#define __NR_quotactl_path 443
> > -__SYSCALL(__NR_quotactl_path, sys_quotactl_path)
> > +/* 443 is reserved for quotactl_path */
> >
> > #define __NR_landlock_create_ruleset 444
> > __SYSCALL(__NR_landlock_create_ruleset, sys_landlock_create_ruleset)
> > --
> > 2.31.1
> >
> --
> Jan Kara <[email protected]>
> SUSE Labs, CR
--
Jan Kara <[email protected]>
SUSE Labs, CR

2021-06-15 08:48:25

by Arnd Bergmann

Subject: Re: [PATCH] quota: finish disable quotactl_path syscall

On Mon, Jun 14, 2021 at 6:45 PM Jan Kara <[email protected]> wrote:
>
> On Mon 14-06-21 17:37:12, Marcin Juszkiewicz wrote:
> > In commit 5b9fedb31e47 ("quota: Disable quotactl_path syscall") Jan Kara
> > disabled quotactl_path syscall on several architectures.
> >
> > This commit disables it on all architectures using unified list of
> > system calls:
> >
> > - arm64
> > - arc
> > - csky
> > - h8300
> > - hexagon
> > - nds32
> > - nios2
> > - openrisc
> > - riscv (32/64)
> >
> > CC: Jan Kara <[email protected]>
> > CC: Christian Brauner <[email protected]>
> > CC: Sascha Hauer <[email protected]>
> > Link: https://lore.kernel.org/lkml/20210512153621.n5u43jsytbik4yze@wittgenstein
> >
> > Signed-off-by: Marcin Juszkiewicz <[email protected]>
>
> Aha, I've missed that one. Thanks for catching this. Arnd, will you take
> this patch or should I take it through my tree?

I don't have any other fixes for 5.13 at the moment, so I would prefer it if
you could pick it up.

Arnd

2021-06-15 09:06:44

by Jan Kara

Subject: Re: [PATCH] quota: finish disable quotactl_path syscall

On Tue 15-06-21 10:45:38, Arnd Bergmann wrote:
> On Mon, Jun 14, 2021 at 6:45 PM Jan Kara <[email protected]> wrote:
> >
> > On Mon 14-06-21 17:37:12, Marcin Juszkiewicz wrote:
> > > In commit 5b9fedb31e47 ("quota: Disable quotactl_path syscall") Jan Kara
> > > disabled quotactl_path syscall on several architectures.
> > >
> > > This commit disables it on all architectures using unified list of
> > > system calls:
> > >
> > > - arm64
> > > - arc
> > > - csky
> > > - h8300
> > > - hexagon
> > > - nds32
> > > - nios2
> > > - openrisc
> > > - riscv (32/64)
> > >
> > > CC: Jan Kara <[email protected]>
> > > CC: Christian Brauner <[email protected]>
> > > CC: Sascha Hauer <[email protected]>
> > > Link: https://lore.kernel.org/lkml/20210512153621.n5u43jsytbik4yze@wittgenstein
> > >
> > > Signed-off-by: Marcin Juszkiewicz <[email protected]>
> >
> > Aha, I've missed that one. Thanks for catching this. Arnd, will you take
> > this patch or should I take it through my tree?
>
> I don't have any other fixes for 5.13 at the moment, so I would prefer it if
> you could pick it up.

OK, thanks for letting me know. I've picked it up.

Honza
--
Jan Kara <[email protected]>
SUSE Labs, CR

2021-06-15 09:18:32

by Christian Brauner

Subject: Re: [PATCH] quota: finish disable quotactl_path syscall

On Tue, Jun 15, 2021 at 10:47:28AM +0200, Jan Kara wrote:
> On Mon 14-06-21 18:44:54, Jan Kara wrote:
> > On Mon 14-06-21 17:37:12, Marcin Juszkiewicz wrote:
> > > In commit 5b9fedb31e47 ("quota: Disable quotactl_path syscall") Jan Kara
> > > disabled quotactl_path syscall on several architectures.
> > >
> > > This commit disables it on all architectures using unified list of
> > > system calls:
> > >
> > > - arm64
> > > - arc
> > > - csky
> > > - h8300
> > > - hexagon
> > > - nds32
> > > - nios2
> > > - openrisc
> > > - riscv (32/64)
> > >
> > > CC: Jan Kara <[email protected]>
> > > CC: Christian Brauner <[email protected]>
> > > CC: Sascha Hauer <[email protected]>
> > > Link: https://lore.kernel.org/lkml/20210512153621.n5u43jsytbik4yze@wittgenstein
> > >
> > > Signed-off-by: Marcin Juszkiewicz <[email protected]>
> >
> > Aha, I've missed that one. Thanks for catching this. Arnd, will you take
> > this patch or should I take it through my tree?
>
> OK, I want this to make it for rc7 so I've pulled this patch to my tree and
> will push it to Linus in a few days.

Looks good, thanks!
Acked-by: Christian Brauner <[email protected]>

>
> Honza
>
> > > diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
> > > index 6de5a7fc066b..d2a942086fcb 100644
> > > --- a/include/uapi/asm-generic/unistd.h
> > > +++ b/include/uapi/asm-generic/unistd.h
> > > @@ -863,8 +863,7 @@ __SYSCALL(__NR_process_madvise, sys_process_madvise)
> > > __SC_COMP(__NR_epoll_pwait2, sys_epoll_pwait2, compat_sys_epoll_pwait2)
> > > #define __NR_mount_setattr 442
> > > __SYSCALL(__NR_mount_setattr, sys_mount_setattr)
> > > -#define __NR_quotactl_path 443
> > > -__SYSCALL(__NR_quotactl_path, sys_quotactl_path)
> > > +/* 443 is reserved for quotactl_path */
> > >
> > > #define __NR_landlock_create_ruleset 444
> > > __SYSCALL(__NR_landlock_create_ruleset, sys_landlock_create_ruleset)
> > > --
> > > 2.31.1
> > >
> > --
> > Jan Kara <[email protected]>
> > SUSE Labs, CR
> --
> Jan Kara <[email protected]>
> SUSE Labs, CR